Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): handle exceptions for function getpass.getuser() #130

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Conversation

XuehaiPan
Copy link
Owner

Issue Type

  • Improvement/feature implementation

Description

Move the getuser() function under a contextlib.suppress(ImportError, OSError) context.

Motivation and Context

Resolves #129

cc @landgraf @quarckster

This would also resolve an incoming change of the exception type in the Python upstream in Python 3.13.

@XuehaiPan XuehaiPan added enhancement New feature or request api Something related to the core APIs labels Jul 12, 2024
@XuehaiPan XuehaiPan merged commit c00b80d into main Jul 12, 2024
2 checks passed
@XuehaiPan XuehaiPan deleted the getuser branch July 12, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Something related to the core APIs enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant