Fix for multiZoneDraftMode (issue 1076) #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ined (reading 'multiZoneDraftMode')
lordphnx
changed the title
Xunnamius
approved these changes
Sep 18, 2024
|
@Xunnamius I'm a total GitHub noob, so bear with me through the signing 😅 |
|
All good 😄, I'll squash merge it in a sec (related issue: vercel/next.js@4cf65d5 and vercel/next.js#68997) |
|
🎉 This PR is included in version 4.0.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NextJS apparently now reads
multiZoneDraftModefromapiContextInside NTARH,
undefinedis passed asapiContext, which causes Next to reactundefined. multiZoneDraftModewhich crashes the test.The fix that works for us is to pass
{}asapiContext,multiZoneDraftModewill still be undefined, but we don't get a "null"pointer