Fix delete button + add view button + refacto urls + support Netbox 4.2 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This contains breaking changes requiring a major release, please update your description aswell for proper changelog information. |
a-belhadj
force-pushed
the
fix_delete
branch
from
83884b0 to
192f9d5
Compare
It's not really breaking as the minimum version of the plugin is 4.0.0 |
URLs changes: - Create: /plugins/ddns/ip-addresses/<int:ipaddress_pk>/extra-dns-name/create/ - Edit: /plugins/ddns/extra-dns-name/<int:pk>/edit/ - Delete: /plugins/ddns/extra-dns-name/<int:pk>/delete/ - View: /plugins/ddns/extra-dns-name/<int:pk>/delete/ Drop support for Netbox version prior to 4.0 Code cleanup to use GenericView
a-belhadj
force-pushed
the
fix_delete
branch
from
192f9d5 to
a85782b
Compare
|
I use it on our production Netbox since 2 weeks and it works well |
a-belhadj
changed the title
a-belhadj
force-pushed
the
fix_delete
branch
4 times, most recently
from
f5b369f to
97e042e
Compare
|
Any update ? |
|
Released with version v1.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove IP addresses id from URL not required to read, modify and delete, changes:
/plugins/ddns/ip-addresses/<int:ipaddress_pk>/extra-dns-name/create//plugins/ddns/extra-dns-name/<int:pk>/edit//plugins/ddns/extra-dns-name/<int:pk>/delete//plugins/ddns/extra-dns-name/<int:pk>/delete/Drop support for Netbox version prior to 4.0
Code cleanup to use GenericView
Add view button list view