Skip to content

Commit

Permalink
Revert "Merge from master to my branch (#680)"
Browse files Browse the repository at this point in the history
This reverts commit 3f49f69.
  • Loading branch information
dorian451 committed Apr 14, 2023
1 parent 613a9f2 commit 3dfc7b4
Show file tree
Hide file tree
Showing 30 changed files with 5,591 additions and 189 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
jobs:
backend-unit-tests:
name: pytest
runs-on: ubuntu-22.04
runs-on: ubuntu-18.04
timeout-minutes: 5
container: python:3.8

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prod-update.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:

strategy:
matrix:
semester: [summer-2023]
semester: [spring-2023]

steps:
- name: Checkout repository
Expand Down
13 changes: 0 additions & 13 deletions docs/contributing/how_to_review.md

This file was deleted.

Binary file removed docs/contributing/img/add_review.png
Binary file not shown.
Binary file removed docs/contributing/img/assign_branch.png
Binary file not shown.
Binary file removed docs/contributing/img/feature_request.png
Binary file not shown.
Binary file removed docs/contributing/img/feature_request_template.png
Binary file not shown.
Binary file removed docs/contributing/img/inprogress_label.png
Binary file not shown.
Binary file removed docs/contributing/img/issue.png
Binary file not shown.
Binary file removed docs/contributing/img/issue_assign.png
Binary file not shown.
Binary file removed docs/contributing/img/issue_listing.png
Binary file not shown.
Binary file removed docs/contributing/img/navigating_to_branch.png
Binary file not shown.
Binary file removed docs/contributing/img/new_issue.png
Binary file not shown.
Binary file removed docs/contributing/img/new_pull_request.png
Binary file not shown.
Binary file removed docs/contributing/img/opening_pull_request.png
Binary file not shown.
Binary file removed docs/contributing/img/pull_request_name.png
Binary file not shown.
15 changes: 0 additions & 15 deletions docs/contributing/opening_an_issue.md

This file was deleted.

26 changes: 0 additions & 26 deletions docs/contributing/working_on_an_issue.md

This file was deleted.

2,834 changes: 2,834 additions & 0 deletions rpi_data/fall-2020.csv

Large diffs are not rendered by default.

5 changes: 0 additions & 5 deletions rpi_data/get-fall-2023.sh

This file was deleted.

7 changes: 0 additions & 7 deletions rpi_data/get-summer-2023.sh

This file was deleted.

6 changes: 3 additions & 3 deletions rpi_data/modules/build_semester.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import os

if __name__ == '__main__':
os.system("SOURCE_URL=https://sis.rpi.edu/reg/zs20230501.htm DEST=out1.csv HEADERS=True python rpi-parse.py")
os.system("SOURCE_URL=https://sis.rpi.edu/reg/zs20230502.htm DEST=out2.csv HEADERS=False python rpi-parse.py")
os.system("SOURCE_URL=https://sis.rpi.edu/reg/zs20230503.htm DEST=out3.csv HEADERS=False python rpi-parse.py")
os.system("SOURCE_URL=https://sis.rpi.edu/reg/zs20200501.htm DEST=out1.csv HEADERS=True python rpi-parse.py")
os.system("SOURCE_URL=https://sis.rpi.edu/reg/zs20200502.htm DEST=out2.csv HEADERS=False python rpi-parse.py")
os.system("SOURCE_URL=https://sis.rpi.edu/reg/zs20200503.htm DEST=out3.csv HEADERS=False python rpi-parse.py")
os.system("cat out1.csv out2.csv out3.csv > out.csv")
2,689 changes: 2,689 additions & 0 deletions rpi_data/spring-2020.csv

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions src/web/src/assets/dark.scss
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,6 @@
.dropdown-item {
color: var(--dark-text-primary) !important;
}
.dropdown-item:hover {
background-color: var(--dark-border-primary) !important;
}

.link {
color: var(--dark-text-primary) !important;
Expand Down
35 changes: 18 additions & 17 deletions src/web/src/components/CourseListing.vue
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<b-list-group-item
class="selected"
button
v-for="section in sortedSections"
v-for="section in course.sections"
:key="section.crn"
@click.stop="toggleCourseSection(section)"
:style="{
Expand All @@ -66,8 +66,7 @@
>
<b-row class="mb-2" align-h="between">
<b-col cols="auto">
{{ section.crn }} - {{ section.sessions[0].section }} -
{{ getInstructor(section.sessions) }}
{{ section.crn }} - {{ section.sessions[0].section }}
</b-col>
<b-col v-if="section.seats_total > 0" cols="auto">
<course-section-seats-badge
Expand Down Expand Up @@ -100,16 +99,21 @@

<script>
import "@/typedef";
import { DAY_SHORTNAMES, readableTime, readableDate } from "@/utils";
import { getBackgroundColor, getBorderColor } from "@/services/ColorService";
import {
faTimes,
faPlus,
faChevronDown,
faChevronUp,
} from "@fortawesome/free-solid-svg-icons";
import CourseSectionSeatsBadge from "./CourseSectionSeatsBadge.vue";
import CourseSectionsOpenBadge from "./CourseSectionsOpenBadge.vue";
// Course Listing by default is a collapsible display of a course and its
// sections and sessions
// However, there are slots available to customize the information displayed
Expand All @@ -124,6 +128,7 @@ export default {
},
props: {
course: Object,
// If true, collapse is open when created
// If lazyLoadCollapse is true, this is ignored
openInitial: {
Expand All @@ -137,6 +142,7 @@ export default {
type: Boolean,
default: false,
},
// Method name of default action
// When body of CourseListing is clicked on, the
// defaultAction is called
Expand All @@ -146,6 +152,7 @@ export default {
type: String,
default: "toggleCollapse",
},
//if this is false the add course + button wont appear
//this is useful for the course explorer
showAddButton: {
Expand All @@ -160,12 +167,15 @@ export default {
faChevronDown,
faChevronUp,
DAY_SHORTNAMES,
// v-model with collapse
// true or false for open or close respectively collapse
showCollapse: !this.lazyLoadCollapse && this.openInitial,
// initially false, set to true on first collapse toggle
// Used for lazy loading
loaded: false,
showAdd: this.showAddButton,
};
},
Expand All @@ -174,10 +184,12 @@ export default {
readableDate,
getBackgroundColor,
getBorderColor,
// Just a wrapper, can't call `[defaultAction]()` in html
callDefaultAction() {
this[this.defaultAction]();
},
/**
* Toggle collapse state
* @param {boolean} collapse If provided, set collapse state
Expand All @@ -186,9 +198,11 @@ export default {
if (!this.loaded) {
this.loaded = true;
}
this.showCollapse =
collapse !== undefined ? collapse : !this.showCollapse;
},
/**
* Toggle course selected state
* Emits removeCourse and addCourse events
Expand All @@ -215,24 +229,11 @@ export default {
this.$emit("addCourseSection", this.course, section);
}
},
//used in the course explorer to show a courses info modal
showInfoModal() {
this.$emit("showCourseInfo", this.course);
},
getInstructor(sessions) {
for (let i = 0; i < sessions.length; i++) {
if (sessions[i].instructor !== "Staff") {
return sessions[i].instructor;
}
}
},
},
computed: {
sortedSections() {
return this.course.sections
.slice()
.sort((a, b) => a.sessions[0].section - b.sessions[0].section);
},
},
};
</script>
Expand Down
6 changes: 1 addition & 5 deletions src/web/src/components/DepartmentList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
params: { subject: major },
}"
>
<b class="majorShort">{{ major }}</b>
<b>{{ major }}</b>
- {{ getLongName(major) }}
</b-button>
</div>
Expand Down Expand Up @@ -69,8 +69,4 @@ export default {
//important because when you click the color changes and thats annoying
background: rgba(108, 90, 90, 0.15) !important;
}
.majorShort {
color: #3395ff;
}
</style>
Loading

0 comments on commit 3dfc7b4

Please sign in to comment.