-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull Request Template #114
Conversation
**Related Issue** closes #113 **Database Changes/Migrations** N/A **Added/Altered API Routes*** N/A **Test Modifications** N/A **Test Procedure** 1. Create a branch 2. Commit a change to that branch 3. Push branch 4. Create Pull Request and fill in PR template
Deploy Link: http://45.33.91.113/ |
Deploy Link: http://172.104.4.199/ |
I think this might be a little overkill. If there's any new routes that are important, they will probably be mentioned in the testing section. Idk, doesn't seem like a hard thing to find in the code. I would add a description field. I would add encouragement for attaching images of the problem and solution (if applicable). |
Agree with this: idea was to solve the problem of API standardization, but yes, appears this isn't the place to do it.
@CoreyBuckley do you maybe mean a place for more info? Is this what you had in mind? If it is description of what is fixed, that should exist in the issue definition.
Yes :) |
Deploy Link: http://172.104.15.142/ |
I think additional info/description should be near the top 😅 |
Additional info is fine, yes. |
Deploy Link: http://45.56.105.19/ |
Related Issue
closes #113
Database Changes/Migrations
N/A
Test Modifications
N/A
Test Procedure
Photos
N/A
Additional Info
Note, you won't be able to test this until merged, appears to be how the github pr template works :(
Please let me know what you think should be altered/added/removed from this template.