Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request Template #114

Merged
merged 4 commits into from
Apr 21, 2020
Merged

Pull Request Template #114

merged 4 commits into from
Apr 21, 2020

Conversation

jshom
Copy link
Contributor

@jshom jshom commented Apr 21, 2020

Related Issue

closes #113

Database Changes/Migrations

N/A

Test Modifications

N/A

Test Procedure

  1. Create a branch
  2. Commit a change to that branch
  3. Push branch
  4. Create Pull Request and fill in PR template

Photos

N/A

Additional Info

Note, you won't be able to test this until merged, appears to be how the github pr template works :(
Please let me know what you think should be altered/added/removed from this template.

**Related Issue**

closes #113

**Database Changes/Migrations**

N/A

**Added/Altered API Routes***

N/A

**Test Modifications**
N/A

**Test Procedure**

1. Create a branch
2. Commit a change to that branch
3. Push branch
4. Create Pull Request and fill in PR template
@jshom jshom changed the title #113 Pull Request Template Apr 21, 2020
@github-actions
Copy link

Deploy Link: http://45.33.91.113/
Branch and Build Info: http://45.33.91.113:3000/info.txt
Expected Time Ready: Tue Apr 21 01:45:27 EDT 2020

@jshom jshom added the Review Ready! Inform team that PR is ready for review label Apr 21, 2020
@github-actions
Copy link

Deploy Link: http://172.104.4.199/
Branch and Build Info: http://172.104.4.199:3000/info.txt
Expected Time Ready: Tue Apr 21 01:49:53 EDT 2020

@CoreyBuckley
Copy link
Contributor

Added/Altered API Routes*

I think this might be a little overkill. If there's any new routes that are important, they will probably be mentioned in the testing section. Idk, doesn't seem like a hard thing to find in the code.

I would add a description field.

I would add encouragement for attaching images of the problem and solution (if applicable).

@jshom
Copy link
Contributor Author

jshom commented Apr 21, 2020

Added/Altered API Routes*

I think this might be a little overkill. If there's any new routes that are important, they will probably be mentioned in the testing section. Idk, doesn't seem like a hard thing to find in the code.

Agree with this: idea was to solve the problem of API standardization, but yes, appears this isn't the place to do it.

I would add a description field.

@CoreyBuckley do you maybe mean a place for more info? Is this what you had in mind? If it is description of what is fixed, that should exist in the issue definition.

I would add encouragement for attaching images of the problem and solution (if applicable).

Yes :)

@github-actions
Copy link

Deploy Link: http://172.104.15.142/
Branch and Build Info: http://172.104.15.142:3000/info.txt
Expected Time Ready: Tue Apr 21 02:01:31 EDT 2020

@CoreyBuckley
Copy link
Contributor

I think additional info/description should be near the top 😅

@CoreyBuckley
Copy link
Contributor

do you maybe mean a place for more info? Is this what you had in mind? If it is description of what is fixed, that should exist in the issue definition.

Additional info is fine, yes.

@github-actions
Copy link

Deploy Link: http://45.56.105.19/
Branch and Build Info: http://45.56.105.19:3000/info.txt
Expected Time Ready: Tue Apr 21 12:34:40 EDT 2020

@jshom jshom merged commit f44d422 into master Apr 21, 2020
@123joshuawu 123joshuawu deleted the pr-template branch May 28, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Ready! Inform team that PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ops — Create Pull Request template
2 participants