Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not staging #607

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Not staging #607

merged 2 commits into from
Nov 1, 2022

Conversation

DarknessUnder
Copy link
Member

Issue

Note which issue number(s) this Pull Request closes. All pull requests should close an issue, if one does not exists, make one. This helps us plan and discuss before we decide on implementation

Example:

closes #113

Database Changes/Migrations

If you added/modified a table, notify people of schema change here

Example:

Added table account_semester_selection for a mapping from a students account and semester to a class and section (aka class/section selections)

Test Modifications

Note added unit/integration tests: (all backend changes should contain unit/integration tests with pytest)

Example:

Added test tests/api/db/test_classinfo.py:test_crn_uniqueness to ensure all classes returned from API call don't have repeat CRNs

Test Procedure

Show procedure to test functionality with a clear procedure

Example:

  1. Create a branch
  2. Commit a change to that branch
  3. Push branch
  4. Create Pull Request and fill in PR template

Photos

Show before and after, capture screenshot/gif of finished feature/bug

Additional Info

More info that would help people review your change

dependabot bot and others added 2 commits June 23, 2022 04:22
Bumps [shell-quote](https://github.com/substack/node-shell-quote) from 1.7.2 to 1.7.3.
- [Release notes](https://github.com/substack/node-shell-quote/releases)
- [Changelog](https://github.com/substack/node-shell-quote/blob/master/CHANGELOG.md)
- [Commits](https://github.com/substack/node-shell-quote/compare/v1.7.2...1.7.3)

---
updated-dependencies:
- dependency-name: shell-quote
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@DarknessUnder
Copy link
Member Author

Dependabot package version update

@DarknessUnder DarknessUnder merged commit edf262e into master Nov 1, 2022
@DarknessUnder DarknessUnder deleted the notStaging branch November 1, 2022 02:27
@DarknessUnder DarknessUnder restored the notStaging branch November 1, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ops — Create Pull Request template
1 participant