Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My branch y2 #659

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

My branch y2 #659

wants to merge 18 commits into from

Conversation

YCK03
Copy link

@YCK03 YCK03 commented Feb 17, 2023

Issue

Note which issue number(s) this Pull Request closes. All pull requests should close an issue, if one does not exists, make one. This helps us plan and discuss before we decide on implementation

Example:

closes #113

Database Changes/Migrations

If you added/modified a table, notify people of schema change here

Example:

Added table account_semester_selection for a mapping from a students account and semester to a class and section (aka class/section selections)

Test Modifications

Note added unit/integration tests: (all backend changes should contain unit/integration tests with pytest)

Example:

Added test tests/api/db/test_classinfo.py:test_crn_uniqueness to ensure all classes returned from API call don't have repeat CRNs

Test Procedure

Show procedure to test functionality with a clear procedure

Example:

  1. Create a branch
  2. Commit a change to that branch
  3. Push branch
  4. Create Pull Request and fill in PR template

Photos

Show before and after, capture screenshot/gif of finished feature/bug

Additional Info

More info that would help people review your change

@EggyRepublic EggyRepublic self-requested a review February 17, 2023 23:05
I tried to make the color gray
…to put in their prerequisites for them to eventually check their prereqs against the courses they are signing up for
Added way to access the page through the header. I also cleaned up more of the page.
@dorian451
Copy link
Contributor

what does this even do?

YCK03 added 10 commits April 1, 2023 11:57
Restructuring prerequisites to have the same department list as the course scheduler.
I overhauled the entire page to make it simpler for me to understand. I made it so that you have 2 input text boxes, one for department code and one for course number, this will output the course onto the page. I then created an erase button in case you want to get rid of a specific course, then I made a function that will delete it off the site with a click on it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ops — Create Pull Request template
2 participants