Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faq dl #741

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Faq dl #741

wants to merge 17 commits into from

Conversation

doinglin
Copy link

Issue

Note which issue number(s) this Pull Request closes. All pull requests should close an issue, if one does not exists, make one. This helps us plan and discuss before we decide on implementation

Example:

closes #113

Database Changes/Migrations

If you added/modified a table, notify people of schema change here

Example:

Added table account_semester_selection for a mapping from a students account and semester to a class and section (aka class/section selections)

Test Modifications

Note added unit/integration tests: (all backend changes should contain unit/integration tests with pytest)

Example:

Added test tests/api/db/test_classinfo.py:test_crn_uniqueness to ensure all classes returned from API call don't have repeat CRNs

Test Procedure

Show procedure to test functionality with a clear procedure

Example:

  1. Create a branch
  2. Commit a change to that branch
  3. Push branch
  4. Create Pull Request and fill in PR template

Photos

Show before and after, capture screenshot/gif of finished feature/bug

Additional Info

More info that would help people review your change

Copy link

@kurodj kurodj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few grammatical errors. Everything else works fine.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think it's better to keep answer_symbol uniform (symbol for first question is A. where as the rest are A:)

  2. For the first answer to "How can I use the Schedule feature?", it should be "at" the top of page rather than "on"

  3. For the first answer to "What is the Explore feature?", it should be "at" the top of page rather than "on"

  4. For the first answer to "How can I use the Pathways Navigation feature?", it should be "at" the top of page rather than "on"

  5. For the second answer to "How can I use the Finals feature?", it should be "finish" rather than "finishing"

liw20
liw20 previously approved these changes Jul 22, 2023
Copy link

@liw20 liw20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a lot of negative space on the sides. But it get the mission and message of yacs across.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ops — Create Pull Request template
6 participants