-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faq dl #741
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few grammatical errors. Everything else works fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I think it's better to keep answer_symbol uniform (symbol for first question is A. where as the rest are A:)
-
For the first answer to "How can I use the Schedule feature?", it should be "at" the top of page rather than "on"
-
For the first answer to "What is the Explore feature?", it should be "at" the top of page rather than "on"
-
For the first answer to "How can I use the Pathways Navigation feature?", it should be "at" the top of page rather than "on"
-
For the second answer to "How can I use the Finals feature?", it should be "finish" rather than "finishing"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a lot of negative space on the sides. But it get the mission and message of yacs across.
fixed the opening to each question
-the questions are now bolded -once a question is clicked the question is underlined -the triangle toggle that indicates that the question expands has been edited to look prettier
transition to left border
Issue
Note which issue number(s) this Pull Request closes. All pull requests should close an issue, if one does not exists, make one. This helps us plan and discuss before we decide on implementation
Example:
Database Changes/Migrations
If you added/modified a table, notify people of schema change here
Example:
Test Modifications
Note added unit/integration tests: (all backend changes should contain unit/integration tests with pytest)
Example:
Test Procedure
Show procedure to test functionality with a clear procedure
Example:
Photos
Show before and after, capture screenshot/gif of finished feature/bug
Additional Info
More info that would help people review your change