-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Front end integration #752
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draft of the professors , club/organization, and pathways entitiy
the title
created functions which should add professors into database - added foreign key to certain tables
- Removed webex from table - planned what other functions to add for the future
created function for getting professor first and last name and stores it in json file
- Implemented function for getting professor name by email - fixed bug where professor table caused YACS to show a blank screen - updated the requirements
- further testing on /api/professor - implementation of remove professor function
- fixed function on app.py - added getter function to get profesor by name - added get prfoesor info by rcsid - modified Professor table
- gave %s values
Functions: - get professor by department - get all professors - get professor phone number by email
- added get_office_hours_by_email - added get_professor_rcs_by_email
implemented all functions except add professor
- added professor function - fix remove professor
- add professors is not working, Internal server error
- compared professor to courses and investigated docker issue
- continued debugging for APIs
- receiving foreign key restraint although there is no foreign key specified
…yacs.n into front_end_integration
Acewvrs
previously approved these changes
Aug 8, 2023
doinglin
previously approved these changes
Aug 8, 2023
dorian451
requested changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I can't see the professor page anywhere :(
- updated tables - ran scripts to update tables - fixed frontend page
deleted useless file
dorian451
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gonna trust you on this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #703
Database Changes/Migrations
Created professors tables to allow professors to be stored in the backend
Test Procedure
Try importing the Professors.JSON file
Example: