Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front end integration #752

Merged
merged 110 commits into from
Oct 13, 2023
Merged

Front end integration #752

merged 110 commits into from
Oct 13, 2023

Conversation

jonha1
Copy link
Contributor

@jonha1 jonha1 commented Jul 14, 2023

Issue #703

Database Changes/Migrations

Created professors tables to allow professors to be stored in the backend

Test Procedure

Try importing the Professors.JSON file

Example:

  1. go to losthost admin
  2. go to import professors VIA JSON
  3. Select Professors.JSON file.
  4. Upload the file.
  5. You shouldreceive a message saying JSON imported succesfully

jonha1 and others added 30 commits February 14, 2023 17:50
draft of the professors , club/organization, and pathways entitiy
created functions which should add professors into database
- added foreign key to certain tables
- Removed webex from table
- planned what other functions to add
for the future
created function for getting professor first and last name and stores it in json file
- Implemented function for getting professor name by email
- fixed bug where professor table caused YACS to show a blank screen
- updated the requirements
- further testing on /api/professor
- implementation of remove professor function
- fixed function on app.py
- added getter function to get profesor by name
- added get prfoesor info by rcsid
- modified Professor table
Functions:
- get professor by department
- get all professors
- get professor phone number by email
- added get_office_hours_by_email
- added get_professor_rcs_by_email
implemented all functions except add professor
- added professor function
- fix remove professor
- add professors is not working, Internal server error
- compared professor to courses and investigated docker issue
- continued debugging for APIs
fixing and testing API calls
- receiving foreign key restraint although there is no foreign key specified
debugged API call for testing and retrieving professor
Acewvrs
Acewvrs previously approved these changes Aug 8, 2023
got rid of useless code for cleaner UI
doinglin
doinglin previously approved these changes Aug 8, 2023
@dorian451 dorian451 self-requested a review September 22, 2023 04:50
Copy link
Contributor

@dorian451 dorian451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I can't see the professor page anywhere :(

@dorian451 dorian451 self-requested a review October 13, 2023 20:40
Copy link
Contributor

@dorian451 dorian451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gonna trust you on this one

@jonha1 jonha1 merged commit 8cf1f83 into master Oct 13, 2023
3 checks passed
@jonha1 jonha1 deleted the front_end_integration branch October 13, 2023 20:42
@jonha1 jonha1 restored the front_end_integration branch October 13, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants