Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

846 feature request class page redesign #848

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

846 feature request class page redesign #848

wants to merge 9 commits into from

Conversation

c-jimmy1
Copy link

Issue

closes #846

Changes

  1. Moved around and styled text for better alignment.
  2. Added horizontal bar below course title.
  3. Added names to define sections, i.e. Prerequisites, Course Description
  4. Added open sections information so you can check open sections within each course. (Created new component file)

Photos
BEFORE:
image

AFTER:
image

Additional Info

Wanted to add feature to select sections from course page to reflect on the selected courses main schedule page but wasn't sure how. Can make a new feature request for it if anyone knows how to.

@c-jimmy1 c-jimmy1 added Review Ready! Inform team that PR is ready for review front-end front-end related (usually in vue.js) labels Nov 28, 2023
@c-jimmy1 c-jimmy1 requested review from jonha1 and dorian451 November 28, 2023 20:25
@c-jimmy1 c-jimmy1 self-assigned this Nov 28, 2023
@c-jimmy1 c-jimmy1 linked an issue Nov 28, 2023 that may be closed by this pull request
Feature Request — Class Page Redesign #846
Open
dorian451
dorian451 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@dorian451 dorian451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorian451 dorian451 dorian451 approved these changes

@jonha1 jonha1 Awaiting requested review from jonha1

At least 2 approving reviews are required to merge this pull request.

Assignees

@c-jimmy1 c-jimmy1

Labels
front-end front-end related (usually in vue.js) Review Ready! Inform team that PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request — Class Page Redesign
2 participants
@c-jimmy1 @dorian451