Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

801 Rewrite Webscraper to use SIS #849

Merged
merged 84 commits into from
Dec 8, 2023
Merged

801 Rewrite Webscraper to use SIS #849

merged 84 commits into from
Dec 8, 2023

Conversation

bnavac
Copy link
Contributor

@bnavac bnavac commented Nov 28, 2023 •
edited
Loading

Issue

Fixes #801

Test Procedure

Run new_parse.py

martig7 and others added 30 commits September 29, 2023 17:01
@martig7
Feature Request — Rewrite webscraper to use SIS login
b7065b0 
Fixes #801
@martig7
Feature Request — Rewrite webscraper to use SIS login
787ee7a 
Fixes #801
@martig7
Feature Request — Rewrite webscraper to use SIS login
865d9e9 
Fixes #801
@bnavac
Added documentation
ce32dce
@bnavac
Finished getCoursesInMajor
ca63dac
@martig7
Feature Request — Rewrite webscraper to use SIS login
58193c9 
Fixes #801
@martig7
Merge branch 'martig7/issue801' of https://github.com/YACS-RCOS/yacs.n …
d656a40 
…into martig7/issue801
@martig7
Feature Request — Rewrite webscraper to use SIS login
9f58b78 
Fixes #801
@bnavac
Added selenium to the requirements file
8221cc2
@bnavac
Commit before redesign
3f68f6c 
May be moving in a different direction with the web scraper, so I'm commiting this so that my work doesn't go ungraded.
@bnavac
Finished formatTeachers
c41bfb3
@bnavac
Finished formatTimes
7071c87
@martig7
Feature Request — Rewrite webscraper to use SIS login
d0a3720 
Fixes #801
@martig7
Merge branch 'martig7/issue801' of https://github.com/YACS-RCOS/yacs.n …
49bc5a6 
…into martig7/issue801
@martig7
Update new_parse.py
b75b991
@bnavac
Finished processSpecial
d4ce31f
@bnavac
Merge branch 'martig7/issue801' of https://github.com/YACS-RCOS/yacs.n …
43fe672 
…into martig7/issue801
@martig7
Feature Request — Rewrite webscraper to use SIS login
c3d016b 
Fixes #801
@martig7
Merge branch 'martig7/issue801' of https://github.com/YACS-RCOS/yacs.n …
2daa11b 
…into martig7/issue801
@bnavac
Finished parseRow
c002074
@bnavac
Merge branch 'martig7/issue801' of https://github.com/YACS-RCOS/yacs.n …
6132751 
…into martig7/issue801
@bnavac
Restructured code
8529c40
@bnavac
Finished course
9953077
@bnavac
Refactored combine
106bc3a
@martig7
Feature Request — Rewrite webscraper to use SIS login
8df81b7 
Fixes #801
@martig7
Merge branch 'martig7/issue801' of https://github.com/YACS-RCOS/yacs.n …
d1dcf73 
…into martig7/issue801
@bnavac
Finished combineInfo
b27f0d2
@bnavac
Merge branch 'martig7/issue801' of https://github.com/YACS-RCOS/yacs.n …
61c959a 
…into martig7/issue801
@gcm-0
Did some commenting.
c6d4e61
@gcm-0
Merge branch 'martig7/issue801' of https://github.com/YACS-RCOS/yacs.n …
553731e 
…into martig7/issue801
@dorian451 dorian451 changed the title Martig7/issue801 edit this name it sucks Nov 28, 2023
@bnavac bnavac changed the title edit this name it sucks no Nov 28, 2023
@martig7 martig7 changed the title no 801 Rewrite Webscraper to use SIS Nov 28, 2023
@jonha1 jonha1 requested a review from dorian451 November 28, 2023 22:37
@martig7 martig7 assigned dorian451 and unassigned dorian451 Nov 28, 2023
@bnavac bnavac requested a review from jonha1 November 29, 2023 02:25
gcm-0 and others added 6 commits November 28, 2023 23:25
@gcm-0
Feature Request — Rewrite webscraper to use SIS login
cff3a34 
Fixes #801
@gcm-0
updated readme
8163be6
@gcm-0
fixed a typo lmao
32ae5a5
@bnavac
Added more documentation
7fd741e
@bnavac
Added code to combine prerequisites
de79d21 
The code should add courses to the prerequisites if the courses are in the raw but aren't in the prereqs already.
@bnavac
Removed test code
4d722b9 
Expanded upon and tested the code here. However, it did not work they way I wanted to and slowed down the program significantly, so it will be removed for now.
@martig7 martig7 mentioned this pull request Dec 5, 2023
Closed
dorian451
dorian451 requested changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@dorian451 dorian451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make it work even if duo passcode isn't the user's default option

dorian451

This comment was marked as duplicate.

Sign in to view

dorian451
dorian451 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@dorian451 dorian451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix intended for users that don't use the duo app by default doesn't work but other than that it's fine

jonha1
jonha1 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@jonha1 jonha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great work.

@dorian451 dorian451 merged commit 0f00a6f into master Dec 8, 2023
4 of 5 checks passed
@dorian451 dorian451 deleted the martig7/issue801 branch December 8, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorian451 dorian451 dorian451 approved these changes

@jonha1 jonha1 jonha1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request — Rewrite webscraper to use SIS login
5 participants
@bnavac @jonha1 @dorian451 @martig7 @gcm-0