Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting//fix trivial linting errors #874

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

linted more files, moved some comments into docstrings

573d7c9
Select commit
Loading
Failed to load commit list.
Open

Add linting//fix trivial linting errors #874

linted more files, moved some comments into docstrings
573d7c9
Select commit
Loading
Failed to load commit list.
codefactor.io / CodeFactor failed Apr 9, 2024 in 29s

15 issues fixed. 472 issues found.

Annotations

Check notice on line 83 in rpi_data/modules/fetch_catalog_course_info.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/fetch_catalog_course_info.py#L83 

Constant name "explicit_coreqs_before_prereqs_syntax_regex" doesn't conform to UPPER_CASE naming style (invalid-name)

Check notice on line 58 in rpi_data/modules/fetch_sis_course_info.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/fetch_sis_course_info.py#L58 

Undefined variable 'Error' (undefined-variable)

Check notice on line 87 in rpi_data/modules/fetch_sis_course_info.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/fetch_sis_course_info.py#L87 

Line too long (122/100) (line-too-long)

Check notice on line 280 in src/api/app.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/api/app.py#L280 

Undefined variable 'SessionDeletePydantic' (undefined-variable)

Check notice on line 44 in src/api/migrations/versions/2023-11-03_make_professor_column_names_match_json_.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/api/migrations/versions/2023-11-03_make_professor_column_names_match_json_.py#L44 

Line too long (116/100) (line-too-long)

Check notice on line 117 in src/api/tests/test_user_course.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/api/tests/test_user_course.py#L117 

Variable name "r" doesn't conform to snake_case naming style (invalid-name)

Check notice on line 97 in rpi_data/modules/fetch_catalog_course_info.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/fetch_catalog_course_info.py#L97 

Unnecessarily calls dunder method __str__. Use str built-in function. (unnecessary-dunder-call)

Check notice on line 51 in tests/rpi-data/modules/test_fetch_catalog_course_info.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/rpi-data/modules/test_fetch_catalog_course_info.py#L51 

Too many local variables (23/15) (too-many-locals)

Check notice on line 8 in tests/rpi-data/modules/test_fetch_catalog_course_info.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/rpi-data/modules/test_fetch_catalog_course_info.py#L8 

Access to a protected member _extract_prereq_from_precoreq_str of a client class (protected-access)

Check notice on line 7 in tests/mock_cache.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/mock_cache.py#L7 

Attribute 'cache_cleared' defined outside __init__ (attribute-defined-outside-init)

Check notice on line 244 in rpi_data/modules/new_parse.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/new_parse.py#L244 

TODO: Accomodate for colspans different than 2. (fixme)

Check notice on line 8 in tests/rpi-data/modules/test_add_school_column.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/rpi-data/modules/test_add_school_column.py#L8 

Bad indentation. Found 2 spaces, expected 4 (bad-indentation)

Check notice on line 16 in src/api/migrations/versions/2023-11-10_fix_professor_column_names.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/api/migrations/versions/2023-11-10_fix_professor_column_names.py#L16 

Constant name "depends_on" doesn't conform to UPPER_CASE naming style (invalid-name)

Check notice on line 81 in rpi_data/modules/fetch_sis_course_info.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/fetch_sis_course_info.py#L81 

Unused variable 'current_course_max_enroll' (unused-variable)

Check notice on line 100 in tests/api/db/test_classinfo.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/api/db/test_classinfo.py#L100 

Unused variable 'err' (unused-variable)

Check notice on line 212 in rpi_data/modules/fetch_catalog_course_info.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/fetch_catalog_course_info.py#L212 

Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)

Check notice on line 96 in src/api/tests/test_user.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/api/tests/test_user.py#L96 

Variable name "r1" doesn't conform to snake_case naming style (invalid-name)

Check notice on line 15 in tests/api/db/test_classinfo.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/api/db/test_classinfo.py#L15 

Trailing whitespace (trailing-whitespace)

Check notice on line 181 in rpi_data/modules/fetch_sis_course_info.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/fetch_sis_course_info.py#L181 

Variable name "df" doesn't conform to snake_case naming style (invalid-name)

Check notice on line 56 in rpi_data/modules/fetch_sis_course_info.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/fetch_sis_course_info.py#L56 

Too many statements (76/50) (too-many-statements)

Check notice on line 127 in rpi_data/modules/fetch_sis_course_info.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/fetch_sis_course_info.py#L127 

Unnecessary parens after 'if' keyword (superfluous-parens)

Check notice on line 103 in rpi_data/modules/fetch_sis_course_info.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/fetch_sis_course_info.py#L103 

Unnecessary parens after 'if' keyword (superfluous-parens)

Check notice on line 157 in src/api/controller/user.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/api/controller/user.py#L157 

Variable name "findUser" doesn't conform to snake_case naming style (invalid-name)

Check notice on line 55 in rpi_data/modules/fetch_catalog_course_info.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

rpi_data/modules/fetch_catalog_course_info.py#L55 

Trailing whitespace (trailing-whitespace)

Check notice on line 19 in src/api/tests/test_bulk_upload.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/api/tests/test_bulk_upload.py#L19 

Variable name "r" doesn't conform to snake_case naming style (invalid-name)
View more details on codefactor.io