Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding major info data #892

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Adding major info data #892

merged 6 commits into from
Nov 19, 2024

Conversation

maggietrebilcock
Copy link
Contributor

The .txt file is just notes about how to interpret the .json file.

Issue

Adding information

Example:

closes #113

Database Changes/Migrations

If you added/modified a table, notify people of schema change here

Example:

Added table account_semester_selection for a mapping from a students account and semester to a class and section (aka class/section selections)

Test Modifications

Note added unit/integration tests: (all backend changes should contain unit/integration tests with pytest)

Example:

Added test tests/api/db/test_classinfo.py:test_crn_uniqueness to ensure all classes returned from API call don't have repeat CRNs

Test Procedure

Show procedure to test functionality with a clear procedure

Example:

  1. Create a branch
  2. Commit a change to that branch
  3. Push branch
  4. Create Pull Request and fill in PR template

Photos

Show before and after, capture screenshot/gif of finished feature/bug

Additional Info

More info that would help people review your change

The .txt file is just notes about how to interpret the .json file.
Added about 1500 lines of major data, which totaled to 18 new majors. I also reformatted how you pick classes from a group of options based on discussion with other YACS developers.
Apparently I did not upload this properly last week. But added some more information based on the new data added.
Added about 12 more majors
Made a bunch new majors (estimated 8 or so)
Changed this to reflect how you pick multiple electives from a list of choices.
Copy link
Contributor

@dorian451 dorian451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@dorian451 dorian451 merged commit d9c8cf1 into YACS-RCOS:master Nov 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ops — Create Pull Request template
2 participants