This repository has been archived by the owner on May 25, 2021. It is now read-only.
Fixed Issue #452 and #421 #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 18, 2019 08:31
…g the course listings also expands the descriptions. Added a space between CRNs and professor names.
…m classes that are available. Rows that are conflicting still have lighter text.
|
@deeyeet Thanks for the PR! Per our last discussion, I don't think clicking the course description should expand anything. Only the expand button should expand stuff. |
Bad-Science
reviewed
Jun 20, 2019
web/src/app/listing/component.html
Outdated
| @@ -42,7 +42,7 @@ | |||
| <span *ngIf="showRemoveButton" (click)="removeButtonClick()" class="remove-button position-absolute" [placement]="['right','bottom','left','top','auto']" ngbPopover="Click on this button to remove class from sidebar" container="body" triggers="mouseenter:mouseleave"> | |||
| <img src="assets/images/remove.svg" /> | |||
| </span> | |||
| <div class="menu position-absolute" (click)="showingMenu=!showingMenu"> | |||
| <div class="menu position-absolute" (click)="showingMenu=!showingMenu" (click)="showingDescription=!showingDescription"> | |||
There was a problem hiding this comment.
I think you should create an expand / toggle function to handle this rather than have two click handlers
added 2 commits
June 25, 2019 08:51
…cription and course listings. Clicking on the description should select the course while highlighting the course should not do anything.
…n that caused errors while YACS refreshed.
|
Nevermind, the bug is still there. |
added 2 commits
June 28, 2019 13:41
…l not select the course. Refreshing works.
Bad-Science
reviewed
Jun 28, 2019
web/src/app/listing/component.ts
Outdated
| // this.selectionService.toggleCourse(this.listing); | ||
| this.showingDescription= !(this.showingDescription); | ||
| // this.showingDescription= !(this.showingDescription); |
Bad-Science
approved these changes
Jul 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanding the descriptions also expands the course listings. Expanding the course listings also expands the descriptions. Added a space between CRNs and professor names.
Edit: Darkened the font of class times, CRNS, instructors and seat info from classes that are available. Rows that are conflicting still have lighter text.
Picture of updated text: https://imgur.com/0zMjNY3