Move gardener dashboard to addons. #897
Conversation
This will allow for switching it off. Signed-off-by: Jens Schneider <schneider@23technologies.cloud>
|
Maybe there should be a "gardener-addons" chart that comes as part of/after the gardener KS? |
|
I also thought about this, but this also feels a little bit cluttered. I do not have a clear opinion on that. Just from the feature perspective the solutions are equivalent. |
|
I agree that functionally there is no difference as the HelmRelease still is going to wait for the same dependencies and install just the same. I agree it's the most minimal change right now. Anyway, flux/gardener.yaml needs to get the healthChecks for dashboard-* removed, to make it work when no dashboard gets deployed. |
|
Indeed...I forgot this. Maybe lets simply keep this open and take another look at it together. Maybe, we find a better solution together. |
Signed-off-by: Jens Schneider <schneider@23technologies.cloud>
Signed-off-by: Jens Schneider <schneider@23technologies.cloud>
Signed-off-by: Jens Schneider <schneider@23technologies.cloud>
Signed-off-by: Jens Schneider <schneider@23technologies.cloud>
|
I just added the upgrade guide to the release notes which worked in my test setup. Could you have another look @gesslein? |
configuration -> addons -> pre-gardener -> gardener
|
I've added a few minor things, mainly dependencies between Kustomization and helm unittest stuff. If those changes are ok for you as well, this PR LGTM |
|
Totally fine... |
This seems to me a little bit cluttered as the dashboard becomes part of the pre-gardener now. However, this seems to be the minimum change solution for the moment, or am I missing something?