Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE-53] 공통 바텀시트 생성 #70

Merged
merged 2 commits into from
Jun 30, 2022
Merged

[ISSUE-53] 공통 바텀시트 생성 #70

merged 2 commits into from
Jun 30, 2022

Conversation

KwonDae
Copy link
Member

@KwonDae KwonDae commented Jun 27, 2022 •
edited
Loading

ISSUE


작업 내용

  • 공통으로 쓸 수 있는 바텀시트를 만들었습니다.
  • 주의깊게 볼 점은 rememberBottomSheetState, rememberBottomSheetScaffoldState, rememberCoroutineScope 요 3가지입니다.
  • 화면마다 커스텀 할 때 xxxBottomSheetScreen 으로 BottomSheetScreen 을 커스텀해서 쓰면 될 것 같아요
  • 영역별로 Modifier.clickable 을 설정해두었는데 가져다 쓸 때 바꿔주면 됩니다.

실행 화면

Screen Shot
ezgif com-gif-maker (2)

Check List

  • PR 제목은 [ISSUE-{N}] PR 제목으로 작성
  • CI/CD 통과 여부
  • 1명 이상의 Approve 확인 후 Merge
  • 관련 이슈 연결

@KwonDae KwonDae added this to the Sprint #5 milestone Jun 27, 2022
@KwonDae KwonDae self-assigned this Jun 27, 2022
jihee-dev
jihee-dev approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@jihee-dev jihee-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

타임 테이블 작업하시느라 힘드셨을 텐데 바텀 시트까지 감사합니다!!!
고생하셨습니당 👍👍👍

presentation/src/main/java/com/yapp/growth/presentation/ui/utils/BottomSheet.kt Outdated
Comment on lines 39 to 40
BottomSheetScaffold(sheetBackgroundColor = Color.Transparent,
sheetPeekHeight = 0.dp,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
BottomSheetScaffold(sheetBackgroundColor = Color.Transparent,
sheetPeekHeight = 0.dp,
BottomSheetScaffold(
sheetBackgroundColor = Color.Transparent,
sheetPeekHeight = 0.dp,

아래 포맷과 동일하게 내려주면 좋을 것 같아요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b1e8b5a
수정했습니다~!

presentation/src/main/java/com/yapp/growth/presentation/ui/utils/BottomSheet.kt
modifier = Modifier
.height(200.dp)
.align(Alignment.BottomCenter)
.clickable(false) { },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 이건 어떤 코드인가여

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

위에 dim 영역인 Box 를 클릭하면 sheetState.collapse() 하도록 해주었는데
Box

  • Surface

구조여서 Surface (바텀시트 영역) 클릭 시 sheetState 에 영향이 안가도록 저렇게 조치했는데 리펙토링 일감일 것 같아요

hoyahozz
hoyahozz approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@hoyahozz hoyahozz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!! 👍👍👍👍👍👍👍👍👍👍👍

@KwonDae KwonDae merged commit 1c81e42 into develop Jun 30, 2022
@KwonDae KwonDae deleted the feature/issue-053-create-bottomSheet branch June 30, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihee-dev jihee-dev jihee-dev approved these changes

@hoyahozz hoyahozz hoyahozz approved these changes

Assignees

@KwonDae KwonDae

Labels
None yet
Projects
None yet
Milestone
Sprint #5
Development

Successfully merging this pull request may close these issues.

[Sprint #5] 메인홈 - 홈 바텀시트
3 participants
@KwonDae @jihee-dev @hoyahozz