Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE-SideEffect] 카카오 로그인 로직 수정 #71

Merged
merged 3 commits into from
Jun 29, 2022
Merged

[ISSUE-SideEffect] 카카오 로그인 로직 수정 #71

merged 3 commits into from
Jun 29, 2022

Conversation

KwonDae
Copy link
Member

@KwonDae KwonDae commented Jun 27, 2022 •
edited
Loading

ISSUE

  • 카카오 로그인 부분 SideEffect, State, Event 사용 로직 수정
  • SplashActivity, LoginActivity 두 부분 모두 수정했습니다

Check List

  • PR 제목은 [ISSUE-{N}] PR 제목으로 작성
  • CI/CD 통과 여부
  • 1명 이상의 Approve 확인 후 Merge
  • 관련 이슈 연결

@KwonDae KwonDae self-assigned this Jun 27, 2022
@KwonDae KwonDae changed the title Feature/refactor kakao login [ISSUE-SideEffect] 카카오 로그인 로직 수정 Jun 27, 2022
jihee-dev
jihee-dev approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@jihee-dev jihee-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!! 👍👍👍

@KwonDae KwonDae merged commit 1078b83 into develop Jun 29, 2022
@KwonDae KwonDae deleted the feature/refactor-kakao-login branch June 29, 2022 13:42
@KwonDae KwonDae added this to the Sprint #4 milestone Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihee-dev jihee-dev jihee-dev approved these changes

@hoyahozz hoyahozz Awaiting requested review from hoyahozz

Assignees

@KwonDae KwonDae

Labels
None yet
Projects
None yet
Milestone
Sprint #4
Development

Successfully merging this pull request may close these issues.
2 participants
@KwonDae @jihee-dev