Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE-76] Api key가 노출되어 있는 문제 해결 #77

Merged
merged 1 commit into from
Jul 1, 2022
Merged

[ISSUE-76] Api key가 노출되어 있는 문제 해결 #77

merged 1 commit into from
Jul 1, 2022

Conversation

jihee-dev
Copy link
Member

@jihee-dev jihee-dev commented Jun 30, 2022 •
edited by KwonDae
Loading

ISSUE


작업 내용

  • Api key가 노출되어 있는 문제 해결
    • secrets gradle plugin을 추가하여 앱 키를 로컬 프로퍼티에서 가져오도록 수정

실행 화면

Screen Shot Screen Shot

Check List

  • PR 제목은 [ISSUE-{N}] PR 제목으로 작성
  • CI/CD 통과 여부
  • 1명 이상의 Approve 확인 후 Merge
  • 관련 이슈 연결

@jihee-dev jihee-dev self-assigned this Jun 30, 2022
@jihee-dev jihee-dev requested a review from KwonDae June 30, 2022 22:00
KwonDae
KwonDae approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@KwonDae KwonDae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@KwonDae KwonDae merged commit f625568 into develop Jul 1, 2022
@jihee-dev jihee-dev deleted the fix/hide-api-key branch July 1, 2022 11:12
@KwonDae KwonDae added this to the Sprint #5 milestone Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KwonDae KwonDae KwonDae approved these changes

Assignees

@jihee-dev jihee-dev

Labels
None yet
Projects
None yet
Milestone
Sprint #5
Development

Successfully merging this pull request may close these issues.

[FIX] API Key가 공개되어 있는 문제 해결
2 participants
@jihee-dev @KwonDae