Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE-78] Api Key 코드 리펙토링 #79

Merged
merged 5 commits into from
Jul 1, 2022
Merged

[ISSUE-78] Api Key 코드 리펙토링 #79

merged 5 commits into from
Jul 1, 2022

Conversation

KwonDae
Copy link
Member

@KwonDae KwonDae commented Jul 1, 2022 •
edited
Loading

ISSUE


작업 내용

  • KAKAO_O_AUTH 를 삭제하고 KAKAO_APP_KEY 로 관리하도록 수정했습니다. (카카오 앱키 재발급 받았습니다)
  • 기존에 build.gradle 에서 property 로 가져오는 로직을 삭제하고 secrets 라이브러리를 통해 BuildConfig 로 대체했습니다.
  • AppModule 에서 BaseUrl 을 Provide 하는 로직을 삭제하고 BuildConfig 로 대체했습니다.

Check List

  • PR 제목은 [ISSUE-{N}] PR 제목으로 작성
  • CI/CD 통과 여부
  • 1명 이상의 Approve 확인 후 Merge
  • 관련 이슈 연결

@KwonDae KwonDae requested a review from jihee-dev July 1, 2022 01:50
@KwonDae KwonDae self-assigned this Jul 1, 2022
jihee-dev
jihee-dev approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@jihee-dev jihee-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아용! 재발급해 주신 앱 키도 지금 깃 시크릿에 업데이트 된 거죵?

@KwonDae KwonDae merged commit 7615811 into develop Jul 1, 2022
@KwonDae KwonDae deleted the refactor/hide-api-key branch July 1, 2022 14:01
@KwonDae KwonDae modified the milestones: Sprint #4, Sprint #5 Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihee-dev jihee-dev jihee-dev approved these changes

Assignees

@KwonDae KwonDae

Labels
None yet
Projects
None yet
Milestone
Sprint #5
Development

Successfully merging this pull request may close these issues.

[FIX] API Key 관련 코드 리펙토링
2 participants
@KwonDae @jihee-dev