[ISSUE-65] 약속관리 - 약속보내기(P_06) 화면 구현 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoyahozz
approved these changes
Jul 18, 2022
Comment on lines
+14
to
+15
| private val parseFormat = SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss", Locale.KOREA) | ||
| private val hourFormat = SimpleDateFormat("HH:mm", Locale.KOREA) |
There was a problem hiding this comment.
요 친구들 ViewModel에서 정제하는게 아니라 Data에서 하나용?
There was a problem hiding this comment.
음 시간표 생성할 때 시간 List 가 필요한데요, 서버에서 내려주지 않고 클라이언트에서 minTime 을 기준으로 시간테이블을 생성해야 해서 data 에서 생성 후 넘겨주고 있어요.
이것도 데이터이기에 데이터 레이어에서 생성 후 넘겨주어야 할 것 같아서 이렇게 구성했습니다
| .padding(start = 20.dp) | ||
| ) { | ||
| Text( | ||
| text = "대원님", style = PlanzTypography.h2, color = Gray900 |
There was a problem hiding this comment.
넵 이부분 API 연동할 때 서버에서 내려주는 이름으로 넣어둘게요!
| <string name="respond_plan_complete_title_text3">성공</string> | ||
| <string name="respond_plan_complete_button_text">확인하기</string> | ||
|
|
||
| <string name="respond_plan_reject_title_text">확인하기</string> |
There was a problem hiding this comment.
확인하기 스트링 리소스가 두 개인데 잘못 들어간거겠죵??
There was a problem hiding this comment.
음 이게 '보내기 성공' 화면과 '약속 거절 확인 화면' 에서의 두개의 버튼 텍스트가 같네요.
이 경우에 통일을 하는게 나을까요 분리하는게 나을까요..?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE
작업 내용
실행 화면
Check List
[ISSUE-{N}] PR 제목으로 작성