-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
메인 브랜치에 개발용 브랜치 반영 #110
Merged
메인 브랜치에 개발용 브랜치 반영 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
유저 탈퇴시 정상적으로 데이터 삭제되지 않는 버그 개선 / 구조 개선 / 테스트 코드 추가 / 일부 authentication 처리 로직 개선
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 내용
구현 요약
API 수정
테스트
통합 테스트 base class 추가
테스트 상 편의를 위해, User 엔티티의 id를 입력하는 생성자 추가
테스트 상 편의를 위해, 테스트용 유저 정적 변수 선언
Category Repository Unit Test 추가
유저 기반 카테고리를 삭제하는 CategoryRepository.deleteAllByUser메소드를 검증하는 레포지토리 테스트 추가
카테고리를 삭제하면 전시데이터도 삭제되는지에 대해, CategoryService.delete 메소드를 검증하는 테스트 추가
기존의 User Service Test를 단위 테스트로 처리하도록 변경
UserService.updateUserName 메소드의 서비스 단위 테스트 추가
유저 삭제 API의 통합 테스트 추가
UserRepository의 단위 테스트 추가
UserRepository.delete를 검증하는 레포지토리 단위 테스트 추가
기타
관련 이슈
close #108