Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notice 도메인 개선 #128

Merged
merged 25 commits into from
Apr 24, 2023
Merged

Notice 도메인 개선 #128

merged 25 commits into from
Apr 24, 2023

Conversation

akalswl14
Copy link
Member

구현 내용

구현 요약

클라이언트에 영향을 끼칠 수 있는 변경 내용

없습니다!

개선 작업

  • Notice 도메인에 헥사고날 아키텍처를 적용
  • 단위 테스트, 통합 테스트 추가
  • 불필요한 Repository 메소드 삭제

개선 사항 블로그 정리

https://magenta-ming.tistory.com/4

관련 이슈

close #124

구현 내용

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@akalswl14
♻️ refactor: 컨트롤러 분리
11d81a5
@akalswl14
♻️ refactor: Dto 네이밍 변경, 생성자 개선
60ac2d9
@akalswl14
♻️ refactor: 각 서비스 분리 및 Inbound Port 추가
72e3c17
@akalswl14
♻️ refactor: Notice Outbound Port, Persistence Adapter 추가
27b0363
@akalswl14
♻️ refactor: Repository 이동
62ad32e
@akalswl14
♻️ refactor: 필요없는 메소드 삭제
a205062
@akalswl14
♻️ refactor: Repository를 사용해서 메소드 로직 구현, 리턴 타입 변경
058082a
@akalswl14
♻️ refactor: 각 서비스에서 포트를 사용하여 로직을 구성하도록 구현
9918cb9
@akalswl14
♻️ refactor: 컨트롤러가 UseCase 인터페이스를 사용하도록 변경
baca62f
@akalswl14
♻️ refactor: 서비스 제거
abdc791
@akalswl14
♻️ refactor: 도메인 모델에 관한 예외는 도메인 패키지로 분류함
eadbedc
@akalswl14
♻️ refactor: Notice 상세 조회시, Port 단계에서 예외를 던지도록 수정
72f8eee
@akalswl14
♻️ refactor: Notice Controller 테스트 추가
48b8635
@akalswl14
♻️ refactor: Notice Adapter Test를 위한 SQL 파일 추가
cf7ad14
@akalswl14
♻️ refactor: Notice Adapter Test추가
9e114fa
@akalswl14
♻️ refactor: 서비스 테스트 추가
43f9124
@akalswl14
♻️ refactor: 기존 서비스 테스트 제거
6c18624
@akalswl14
♻️ refactor: 접근 제어자 수정
0ee24e6
@akalswl14 akalswl14 requested a review from le2sky April 21, 2023 01:22
@akalswl14 akalswl14 self-assigned this Apr 21, 2023
@akalswl14 akalswl14 added 유지 보수 리팩터링 테스트 테스트 관련 labels Apr 21, 2023
le2sky
le2sky reviewed Apr 21, 2023
View reviewed changes
Copy link
Member

@le2sky le2sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

의존성도 [ in -> applic[domain]ation <- out ] 으로 적절히 흐르고 테스트 코드도 잘 작성하신 것 같아요 👍👍 몇 가지 코멘트 달아놨으니 확인 부탁드려요!

src/main/java/com/yapp/artie/domain/notice/adapter/in/web/GetNoticeDetailController.java Show resolved Hide resolved
...main/java/com/yapp/artie/domain/notice/adapter/out/persistence/NoticePersistenceAdapter.java Show resolved Hide resolved
...main/java/com/yapp/artie/domain/notice/adapter/out/persistence/NoticePersistenceAdapter.java Outdated Show resolved Hide resolved
src/main/java/com/yapp/artie/domain/notice/application/service/GetNoticeDetailService.java Outdated Show resolved Hide resolved
src/test/java/com/yapp/artie/domain/notice/application/service/GetNoticeDetailServiceTest.java Outdated Show resolved Hide resolved
src/test/java/com/yapp/artie/domain/notice/application/service/GetNoticeListServiceTest.java Show resolved Hide resolved
le2sky
le2sky reviewed Apr 22, 2023
View reviewed changes
Copy link
Member

@le2sky le2sky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM입니다👍👍 @Repository만 제거하면 될 것 같아요!

영속성 어댑터의 트랜잭션은 음... 제 생각에는 readonly로 걸리긴 할 것 같아요! 지연 로딩 이슈는 해당 도메인에서는 발생하지 않을 것 같아서요 Service의 @Transactional은 생략 가능할 것 같아요 고생하셨습니다!

++ import 최적화도 잘되어 있고 엄청 섬세하시군요! 그 readonly 관련해서 궁금하실까봐 SimpleJpaRepository 일부 코드 첨부합니다!

image

src/main/java/com/yapp/artie/domain/notice/adapter/in/web/GetNoticeDetailController.java Show resolved Hide resolved
src/main/java/com/yapp/artie/global/common/annotation/WebAdapter.java Show resolved Hide resolved
src/main/java/com/yapp/artie/domain/notice/adapter/out/persistence/NoticeRepository.java Outdated Show resolved Hide resolved
@akalswl14
♻️ refactor: 불필요한 @respository 어노테이션 제거
e3b6755 
JPA Repository는 자동으로 빈이 등록되므로, @respository 어노테이션을 제거함
@akalswl14
Copy link
Member Author

@le2sky
추가적인 코멘트를 남겨두었어요! 확인 후에 추가 코멘트가 없다면 머지 부탁드립니다 😸

le2sky
le2sky reviewed Apr 24, 2023
View reviewed changes
Copy link
Member

@le2sky le2sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 고생 많으셨어요 👍👍

@le2sky le2sky merged commit 4396ffb into develop Apr 24, 2023
@akalswl14 akalswl14 deleted the refactor/124 branch April 27, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@le2sky le2sky le2sky left review comments

Assignees

@akalswl14 akalswl14

Labels
유지 보수 리팩터링 테스트 테스트 관련
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akalswl14 @le2sky