Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

유저 가입일 조회 API 추가 #132

Merged
merged 2 commits into from
Apr 29, 2023
Merged

유저 가입일 조회 API 추가 #132

merged 2 commits into from
Apr 29, 2023

Conversation

akalswl14
Copy link
Member

@akalswl14 akalswl14 commented Apr 27, 2023 •
edited
Loading

구현 내용

구현 요약

  • 유저 가입일 조회 API 추가
    • 컨트롤러, 서비스, Response, Query 추가
    • LoadUserPort 인터페이스에 loadUserJoinDate 메소드 추가
    • UserPersistenceAdapter 클래스에 loadUserJoinDate 메소드 추가

관련 이슈

close #131

구현 내용

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@akalswl14 akalswl14 added the 기능 구현 기능 구현 label Apr 27, 2023
@akalswl14 akalswl14 requested a review from le2sky April 27, 2023 23:57
@akalswl14 akalswl14 self-assigned this Apr 27, 2023
akalswl14
akalswl14 commented Apr 28, 2023
View reviewed changes
Copy link
Member Author

@akalswl14 akalswl14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@le2sky 유저 가입일 조회 API 추가한 PR 확인 부탁드립니당~! 🙇🙇🙇🙇

@akalswl14 akalswl14 marked this pull request as ready for review April 28, 2023 00:06
@akalswl14 akalswl14 changed the title Feature/131 유저 조회 API 추가 Apr 28, 2023
le2sky
le2sky reviewed Apr 29, 2023
View reviewed changes
Copy link
Member

@le2sky le2sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akalswl14 고생하셨어요👍👍 코드 반영해둘게요!

아직까지는 괜찮지만, user.port.in 패키지에 새로운 게 추가되면 Query, UseCase를 하위 패키징해도 좋을 것 같아요!

...test/java/com/yapp/artie/domain/user/adapter/out/persistence/UserPersistenceAdapterTest.java Show resolved Hide resolved
@le2sky le2sky merged commit 2129429 into develop Apr 29, 2023
@le2sky le2sky deleted the feature/131 branch April 29, 2023 22:22
@akalswl14
Copy link
Member Author

@akalswl14 고생하셨어요👍👍 코드 반영해둘게요!

아직까지는 괜찮지만, user.port.in 패키지에 새로운 게 추가되면 Query, UseCase를 하위 패키징해도 좋을 것 같아요!

저도 동의합니다! Response 부분 또한 구분하면 좋을 것 같다고 생각했어요, 의견 감사드려요 :)

@akalswl14 akalswl14 changed the title 유저 조회 API 추가 유저 가입일 조회 API 추가 May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@le2sky le2sky le2sky left review comments

Assignees

@akalswl14 akalswl14

Labels
기능 구현 기능 구현
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akalswl14 @le2sky