Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

카테고리 목록 조회시, 카테고리가 없으면 404 에러 발생 #149

Merged
merged 1 commit into from
Jun 1, 2023
Merged

카테고리 목록 조회시, 카테고리가 없으면 404 에러 발생 #149

merged 1 commit into from
Jun 1, 2023

Conversation

le2sky
Copy link
Member

@le2sky le2sky commented May 31, 2023

구현 내용

구현 요약

  • [GET] /category : 카테고리 목록 조회
    • 기존 로직은 사용자의 카테고리가 존재하지 않다면 404 에러를 발생
    • emptyList를 반환하도록 기능 수정

관련 이슈

#143

구현 내용

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@le2sky le2sky added the 기능 수정 허걱 label May 31, 2023
@le2sky le2sky requested a review from akalswl14 May 31, 2023 18:35
@le2sky le2sky self-assigned this May 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

le2sky
le2sky commented May 31, 2023
View reviewed changes
Copy link
Member Author

@le2sky le2sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

카테고리 수가 적어도 한 개 이상인지 검증하는 로직을 제거했습니다! 리뷰 부탁합니다 😃

src/main/java/com/yapp/artie/domain/archive/service/CategoryService.java Show resolved Hide resolved
src/main/java/com/yapp/artie/domain/archive/service/CategoryService.java Show resolved Hide resolved
src/test/java/com/yapp/artie/domain/archive/service/CategoryServiceTest.java Show resolved Hide resolved
akalswl14
akalswl14 approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@akalswl14 akalswl14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100점 만점에 만점 입니다요 💯

@akalswl14 akalswl14 merged commit de64beb into develop Jun 1, 2023
@le2sky le2sky deleted the fix/143 branch June 1, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akalswl14 akalswl14 akalswl14 approved these changes

Assignees

@le2sky le2sky

Labels
기능 수정 허걱
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@le2sky @akalswl14