Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat #111] 배치 알림, FCM 토큰 엔티티 작업 #112

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

dlswns2480
Copy link
Contributor

⛏ 이슈 번호

close #111

📍 리뷰 포인트

  • 배치 알림에 createdAt 있는데 전송 시점이 필요할 지.. 있으면 직관적이라 조은 것 같긴합니다! 엔티티 필드 리뷰 부탁!

@dlswns2480 dlswns2480 self-assigned this Aug 22, 2024
@dlswns2480 dlswns2480 linked an issue Aug 22, 2024 that may be closed by this pull request
3 tasks
Copy link
Member

@jimin3263 jimin3263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

흠 제 생각엔 전송 시점 칼럼 따로 두는게 나을 것 같은데욤..
실제 알림 발송시 일괄 +7 연산 한 번 더 하는 것보다 건건이 들어올 때 해두는게 낫지 않을까염 ?..

@dlswns2480 dlswns2480 merged commit 8dd9888 into develop Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

배치용 알림 엔티티, FCM토큰 엔티티
2 participants