[feat #116] 알림 전송 배치 작업 #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
jimin3263
reviewed
Aug 27, 2024
Comment on lines
+17
to
+25
| override fun loadAllByShouldBeSentAt(now: LocalDate, pageable: Pageable): Page<AlertBatch> { | ||
| return alertBatchRepository.findAllByShouldBeSentAtAfterAndSent(now, false, pageable) | ||
| .map { it.toDomain() } | ||
| } | ||
|
|
||
| override fun send(alertBatch: AlertBatch) { | ||
| alertBatchRepository.findByIdOrNull(alertBatch.id) | ||
| ?.sent() | ||
| } |
There was a problem hiding this comment.
알림 설정 (y) 로 하면 알림 등록하는 부분은.. 이전에 커밋했던가요 ..?
There was a problem hiding this comment.
리뷰 이상 없으면 컨텐츠 생성, 수정작업에 해당 로직 추가하려했습니다! 지금은 없슴다ㅎ
jimin3263
reviewed
Aug 27, 2024
| ) : ItemReader<AlertBatch> { | ||
|
|
||
| private var currentPage: Int = 0 | ||
| private val pageSize: Int = 50 |
There was a problem hiding this comment.
pageSIze랑 chunkSize 는 같이 관리해도 좋을 것 같아여 ! 항상 같은 값으로 설정해야하니까
jimin3263
reviewed
Aug 27, 2024
Comment on lines
32
to
41
| fun sendAlertStep() = batch { | ||
| step("sendAlertStep") { | ||
| chunk(50, transactionManager, fun SimpleStepBuilderDsl<AlertBatch, AlertBatch>.() { | ||
| reader(alertReader) | ||
| processor(alertProcessor) | ||
| writer(alertWriter) | ||
| transactionAttribute(DefaultTransactionAttribute(TransactionDefinition.PROPAGATION_NOT_SUPPORTED)) | ||
| }) | ||
| } | ||
| } |
jimin3263
reviewed
Aug 27, 2024
Comment on lines
+12
to
+23
| companion object { | ||
| private const val POOL_SIZE = 3 | ||
| } | ||
|
|
||
| @Bean("schedulerTask") | ||
| fun taskScheduler(): TaskScheduler { | ||
| val executor = ThreadPoolTaskScheduler() | ||
| executor.poolSize = POOL_SIZE | ||
| executor.threadNamePrefix = "scheduler-thread-" | ||
| executor.initialize() | ||
| return executor | ||
| } |
There was a problem hiding this comment.
cpu 코어 1이니까 2로하려다가 3으로 했습니다! 근데 2로 수정하겠습니다
jimin3263
reviewed
Aug 27, 2024
Comment on lines
11
to
16
| @Query( | ||
| """ | ||
| update AlertContentEntity ac set ac.deleted = true | ||
| where ac.id in :ids | ||
| """ | ||
| ) |
There was a problem hiding this comment.
이거 전송 완료했으면 그냥 하드딜리트 해도 될듯여 ㅇㅁㅇ? 알림 테이블에도 또 남으니까..
|
@jimin3263 AlertContent로 컨텐츠들을 전부 조회하는 게 번거롭다는 거였는데 알림 가는 시점 기준의 데이터로 알림 보내는 것이라는 중요한 사실을 망각하고 있었습니다.. 요거 로직 수정하겠습니다! 엔티티도 기존것으로 수정하겠습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛏ 이슈 번호
close #116
📍 리뷰 포인트
📝 참고사항(Optional)
Item Reader
Item Processor
Item Writer