#67,75 - Cursor Based Pagination을 도입하고, Sent Vote 스펙을 변경한다. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sectionr0
approved these changes
Aug 8, 2024
Comment on lines
27
to
25
| val voteResults = votes.associateWith { getSentVotes(it, user) } | ||
| val votes = VoteServiceHelper.findVotesOrderByDateDesc(votePort, user, cursorId, limit + 1) | ||
| val classmates = VoteServiceHelper.findClassmatesByUser(userPort, user) | ||
| val voteResults = votes.take(limit.toInt()).associateWith { getSentVotes(it, user, classmates) } | ||
|
|
||
| return SentVotesResponses.from(voteResults) | ||
| return SentVotesResponses.from(voteResults, votes.size.toLong() == limit + 1) |
There was a problem hiding this comment.
여기에 limit + 1 은 어떤의미일까요?!
There was a problem hiding this comment.
쿼리를 한번 더 날리는 것이 아니라, limit 기준에서 1개 더 가져와서, 만일 한개가 더 존재한다면 다음 페이지가 있는 것으로 처리하고 있어용!!
Comment on lines
120
to
136
| if (cursorId == null) { | ||
| return voteJpaRepository.findAllBySchoolIdAndGradeAndClassNumberOrderByDateDesc( | ||
| schoolId, | ||
| grade, | ||
| classNumber, | ||
| Long.MAX_VALUE, | ||
| limit | ||
| ) | ||
| } | ||
| return voteJpaRepository.findAllBySchoolIdAndGradeAndClassNumberOrderByDateDesc( | ||
| schoolId, | ||
| grade, | ||
| classNumber, | ||
| cursorId, | ||
| limit | ||
| ) | ||
| } |
There was a problem hiding this comment.
커서가 null 인 부분에 따라 repository 에서 분기처리를 하고 계시는군요..!
혹시 controller나 service 쪽에서 미리 확인 후 하시는건 어떠신가요??
이전에 제가 커서 기반 했을 때 common 모듈에다가
object CursorUtils {
fun getEffectiveCursorId(cursorId: Long?): Long {
return cursorId?.takeIf { it != 0L } ?: Long.MAX_VALUE
}
}해당 오브젝트를 만들어 놨어요!
val cursorValue = getEffectiveCursorId(cursorId)이런 형식으로 앞 단에서 미리 값이 없는걸 확인하면 조금 더 코드가 깔끔해 질 것 같아서요!
재연짱이 한번 보고 판단해서 적용해주세요!
There was a problem hiding this comment.
오우 CursorUtil이 있군요 이 부분 적용할게용~!
There was a problem hiding this comment.
이 부분은 확실히 적용하기를 잘헀네요. 서비스 부분에서 이 부분을 판단해주는 것이 훨씬 맞는 선택인 것 같아요 🥰
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 🔗 관련 이슈
2. 📄 구현한 내용 또는 수정한 내용
간단하게 Cursor Based Pagination을 도입하고 Sent Vote 스펙을 변경했어요!!
3. 🙌 추가적으로 알리고 싶은 내용
4. 🙄 TODO / 고민하고 있는 것들
5. ✅ 배포 Checklist