#86 - 사용자의 기본 프로필을 설정 및 차단된 유저의 프로필을 설정한다 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpeel5839
approved these changes
Aug 14, 2024
Comment on lines
+8
to
+17
| @Configuration | ||
| @Profile("!local") | ||
| class TimeZoneConfig { | ||
|
|
||
| @PostConstruct | ||
| fun timeZoneSetUp() { | ||
| TimeZone.setDefault(TimeZone.getTimeZone("Asia/Seoul")) | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
기천짱 미안해요. 여기다가 커밋 끼워넣었어잉 봐줘잉
이전에는 timezone 설정이 제대로 되어 있지 않아, 투표 독려도 정확하지 않은 시간에 들어갔었어요.
하지만, 이 설정으로 인해, 투표 독려가 실행되는 시각인 9,15,21시 중 9시에 정확히 잘 실행되는 것을 볼 수 있어요.
| @@ -15,7 +16,7 @@ object AuthFixture { | |||
| return SignUpRequest( | |||
| signUpToken = "signUpToken", | |||
| name = "Test User", | |||
| gender = "male", | |||
| gender = Gender.MALE, | |||
There was a problem hiding this comment.
오우 쮓, 이거 Notification과 관련이 있는뎅
There was a problem hiding this comment.
이것도 좀만 커밋 밀어넣을게용 허허허 ^.^
| @@ -11,7 +12,7 @@ class ReceivedVoteNotificationServiceTest : BehaviorSpec({ | |||
| given("남학생이 투표를 완료했을 때") { | |||
| val service = ReceivedVoteNotificationService() | |||
| `when`("투표를 받은이에게") { | |||
| val notification = service.getNotification(100L, "female") | |||
| val notification = service.getNotification(100L, Gender.FEMALE) | |||
| @@ -29,7 +30,7 @@ object UserFixture { | |||
| role = Role.USER, | |||
| name = "TestUser", | |||
| introduction = UserIntroduction.from("hello"), | |||
| gender = "male", | |||
| gender = Gender.MALE, | |||
There was a problem hiding this comment.
자기야 이걸로 인해서 Postman 스펙도 조금 바뀌었엉 확인해줘잉
Comment on lines
+13
to
+14
| hasNext = hasNext, | ||
| lastCursorId = messages.lastOrNull()?.id ?: 0L |
| import org.springframework.stereotype.Component | ||
| import java.time.LocalDate | ||
|
|
||
| @Component | ||
| class ReceivedVoteNotificationService { | ||
|
|
||
| fun getNotification(userId: Long, gender: String): Notification { | ||
| fun getNotification(userId: Long, gender: Gender): Notification { |
There was a problem hiding this comment.
아니 이거 어떻게 알고 바꿔줬어요?? 어디서 컴파일 에러 떴나?? 어떻게 알았지;;
kpeel5839
reviewed
Aug 14, 2024
Comment on lines
+38
to
+50
| val updatedIntroduction = profile.introduction ?: loginUser.introduction.introduction | ||
| val updatedProfile = loginUser.profile.update( | ||
| backgroundColor = profile.profile?.backgroundColor ?: loginUser.profile.backgroundColor, | ||
| iconUrl = profile.profile?.iconUrl ?: loginUser.profile.iconUrl | ||
| ) | ||
|
|
||
| val updateProfile = loginUser.profile.update( | ||
| backgroundColor = profile.profile.backgroundColor, | ||
| iconUrl = profile.profile.iconUrl | ||
| val updatedUser = loginUser.copy( | ||
| introduction = UserIntroduction.from(updatedIntroduction), | ||
| profile = updatedProfile | ||
| ) | ||
|
|
||
| profilePort.save(updateProfile) | ||
| userPort.save(updateIntroduction) | ||
| profilePort.save(updatedProfile) | ||
| userPort.save(updatedUser) |
There was a problem hiding this comment.
근데, 차단된 유저의 프로필 설정은 어디있나요? 기존 코드로 가더라도 괜찮아서 변경사항에 포함안되어 있는건가요?
There was a problem hiding this comment.
지금 추가하려고요,,, 3시간 전에 받았어용
…YAPP-Github/WeSpot-Backend into feature/#86-profile-refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 🔗 관련 이슈
2. 📄 구현한 내용 또는 수정한 내용
3. 🙌 추가적으로 알리고 싶은 내용
투표 쪽은 재연짱이 담당해서 일단 노션에 있는 것만 넣었습니다! 추가적으로 더 넣어주세요!
(config 에 validate로 바꿔도 될 것 같네요 이젠👀)
4. 🙄 TODO / 고민하고 있는 것들
5. ✅ 배포 Checklist