-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#97 - 카카오 템플릿 메시지를 조회할 수 있다. #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굉장히 간단하군용? 바쁘실텐데 테스트도 짜신 거 너무 굳~! 코멘트 조금 남겼는데 한번만 확인해주세용~~ 🥰🥰
@@ -175,7 +175,7 @@ class AuthService( | |||
fcm = savedFcm, | |||
setting = null | |||
) | |||
userPort.save(updatedUser) | |||
val save = userPort.save(updatedUser) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분은 의미없는 변수 추출같네요?!
@RestController | ||
@RequestMapping("/api/v1/auth") | ||
class KakaoTemplateController ( | ||
private val kakaoTemplateService: KakaoTemplateService |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usecase를 주입받아야 할 것 같은데 맞을까요?
TELL, | ||
FIND |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이건 어떤 의미를 가지죵?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. 🔗 관련 이슈
2. 📄 구현한 내용 또는 수정한 내용
3. 🙌 추가적으로 알리고 싶은 내용
4. 🙄 TODO / 고민하고 있는 것들
5. ✅ 배포 Checklist