Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#97 - 카카오 템플릿 메시지를 조회할 수 있다. #98

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

sectionr0
Copy link
Contributor

1. 🔗 관련 이슈

2. 📄 구현한 내용 또는 수정한 내용

  • 카카오 메시지 템플릿 도메인 추가 및 조회

3. 🙌 추가적으로 알리고 싶은 내용

4. 🙄 TODO / 고민하고 있는 것들

5. ✅ 배포 Checklist

  • 본인을 Assign 해주세요.
  • 본인을 제외한 백엔드 개발자를 리뷰어로 지정해주세요.
  • 변경된 DB 업데이트 해주세요. (꼭 해주세요 배포 안돼요!!!)

@sectionr0 sectionr0 added 🌱기능🌱 새로운 기능을 추가해요 ! 🥭망고🥭 24기 조기천 labels Aug 20, 2024
@sectionr0 sectionr0 self-assigned this Aug 20, 2024
Copy link
Contributor

@kpeel5839 kpeel5839 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굉장히 간단하군용? 바쁘실텐데 테스트도 짜신 거 너무 굳~! 코멘트 조금 남겼는데 한번만 확인해주세용~~ 🥰🥰

@@ -175,7 +175,7 @@ class AuthService(
fcm = savedFcm,
setting = null
)
userPort.save(updatedUser)
val save = userPort.save(updatedUser)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 의미없는 변수 추출같네요?!

@RestController
@RequestMapping("/api/v1/auth")
class KakaoTemplateController (
private val kakaoTemplateService: KakaoTemplateService
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usecase를 주입받아야 할 것 같은데 맞을까요?

Comment on lines +4 to +5
TELL,
FIND
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 어떤 의미를 가지죵?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 주석 추가해놓을게요!
해당 상황일때 관련한 카카오톡 메시지 템플릿이에요!

TELL : 친구에게 알려주기
FIND : 찾는 친구가 없을때

image

@github-actions github-actions bot added the 🌟머지 해주세요🌟 머지해주셔! label Aug 20, 2024
@sectionr0 sectionr0 merged commit fadb988 into develop Aug 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟머지 해주세요🌟 머지해주셔! 🌱기능🌱 새로운 기능을 추가해요 ! 🥭망고🥭 24기 조기천
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants