feat : 공연 알림 저장 후 조회 구현 #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmizz
requested changes
Sep 27, 2024
| @Getter | ||
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | ||
| @Table(name = "show_alarm") | ||
| public class ShowAlarm extends BaseEntity { |
| ); | ||
| } | ||
|
|
||
| @GetMapping("/activate") |
There was a problem hiding this comment.
리뷰 포인트: 2
activate는 뭔가 활성화 상태...인 거 같아서, 화면단에서 활성화 되어 있단 의미를 많이 주는 거 같아요
unread 같은 걸로, row의 상태를 판별하는 건 어때요?
| private String content; | ||
|
|
||
| @Column(name = "checked", nullable = false) | ||
| private boolean checked; |
There was a problem hiding this comment.
리뷰 포인트: 3
checked 변수가 뭔지 몰랐어요..! boolean 느낌이 안 나서... isRead, hasRead 같은 걸로 가능할까욥?
| include (":app:domain:common-domain") | ||
|
|
||
| include (":app:infrastructure") | ||
| include (":app:infrastructure:fcm") | ||
| include (":app:batch") | ||
|
|
||
| include 'app:api:alarm-api' | ||
| findProject(':app:api:alarm-api')?.name = 'alarm-api' |
There was a problem hiding this comment.
리뷰 포인트: 1
오 요건 뭐에요?? 처음보는데, 코틀린 elvis 연산자 같기도 하고..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😋 작업한 내용
🙏 PR Point
👍 관련 이슈