Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings Saving #26

Closed
mcjojo3 opened this issue Mar 18, 2023 · 7 comments
Closed

Settings Saving #26

mcjojo3 opened this issue Mar 18, 2023 · 7 comments
Assignees
@EliteAsian123
Labels
Enhancement New feature or request

Comments

@mcjojo3
Copy link

mcjojo3 commented Mar 18, 2023

Heya, noticed that players aren't saved on quit, is this intended? Like is it just not implemented yet?
@EliteAsian123
Copy link
Member

Hi!

Unfortunately, this is not implemented yet, but it is most definitely planned. I will keep this issue open as a reminder to me :)

Apologies for any inconveniences.

@EliteAsian123 EliteAsian123 added the Enhancement New feature or request label Mar 18, 2023
@EliteAsian123 EliteAsian123 changed the title Saving Players? Settings Saving Mar 18, 2023
@EliteAsian123 EliteAsian123 self-assigned this Mar 18, 2023
@mcjojo3
Copy link
Author

mcjojo3 commented Mar 19, 2023

Sounds good, love the progress soo far. Also quick question, are longer highway settings planned?

@EliteAsian123
Copy link
Member

Thanks! Yup, full customizability of everything is planned! That comes later, though, unfortunately.

@mcjojo3
Copy link
Author

mcjojo3 commented Mar 21, 2023

Awesome, I love the progress and the constant updates so far! Keep it up!

@EliteAsian123
Copy link
Member

Thanks for the kind words! I'm trying to update as much as possible right now, and I'm glad that people like that. I've been needing a whole new settings system for a while now, so I'll probably need to get started on that sooner or later. Thanks again!

@EliteAsian123
Copy link
Member

Basic settings now save in e4e8555. Input bindings next!

@EliteAsian123
Copy link
Member

Binds now save in dd86abb. Due to technical constraints, players will not save for now, but the binding part does save making it a lot easier.

Purplo-cf pushed a commit to Purplo-cf/YARG that referenced this issue May 14, 2024
@TheNathannator
Even more Moonscraper refactors (YARC-Official#26)
c6e8119 
* Split out parser process lists into their own files

* Move .chart special phrase processing to process lists

* Remove specialized phrase parsing methods from .mid parser

* Add Solo special phrase type instead of using text events for them

* Add solo phrases to unit tests

* Use regex for text event handling
Nothing else has to check for brackets anymore, among other things

* Properly parse in lyric events on .mid vocal tracks

* Rewrite .chart global section parsing and use regex for detecting sections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EliteAsian123 EliteAsian123

Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EliteAsian123 @mcjojo3