No Overstrum Before/After Chart. Drum Freestyle soon to come. #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to disable overstrums/miss before chart starts or after chart ends. Also needed for later implementing drum freestyles. Code has a few issues: - Only allows 1 overstrum before missing again - If you strum at all before the chart starts, it'll count towards the first note and you can hit it without strumming on time. Only seems to affect the first note of the chart. I'm committing this so Nate/drumbs can take a look at it, and once it's fixed I can start to implement drum freestyle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New code stops combo breaks before the chart starts and after the code ends. (All credit for that goes to TheNathannator/drumbs, I just kinda put it together)
Works for both 5 Fret Guitar and Drums, hasn't yet been implemented into Real Guitar.
This code will be reused later for Freestyle Drums, however I haven't yet committed any of that since it's using non-original sound effects for the time being. Once I can get original samples, either by myself or through someone on the server, I'll start pushing the code for that.