Small refactor around loading a song entry's audio #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sonicfind
commented
Jul 8, 2023
sonicfind
commented
- Simplify the stem channel inheritance hierarchy a bit
- Split the ExConSongEntry stem map into the separate stems - allows easier stem type-base audio removal when specified on audio load.
- Move MoggInfoGeneration function into the ConEntry class directly
+ Currently only ini entries have it implemented
RileyTheFox
requested changes
Jul 8, 2023
sonicfind
force-pushed
the
Bass-Mogg-Refactor
branch
from
a1dcdc2
to
bfc33ca
Compare
+ Alter CONEntry stem map organization: instead of holding a combined list/dictionary of stem values, we'll keep them separated and generate a combined list at call time.
sonicfind
force-pushed
the
Bass-Mogg-Refactor
branch
from
bfc33ca
to
c8916b2
Compare
Refactor Mogg Stem subclass to no longer hold a list of channels *while also* inheriting from the IStemChannel interface. Just inherit from BassStemChannel + Change the IStemMixer Dictionary values to lists of channels.
sonicfind
force-pushed
the
Bass-Mogg-Refactor
branch
from
c8916b2
to
930d4b5
Compare
RileyTheFox
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.