DMX support, "Advanced" tab, Stagekit toggle #670
Conversation
Added scan (dmx over ethernet) support. Added an advanced settings tab. Added ability to turn off the stage kit.
|
Seems like sACN does have a NuGet package with a license. Can you confirm that this is the same package, and if so, attempt to use it via NuGetForUnity instead of importing the files? |
Same thing. He just added the license today when I e-mailed him. :) The difference being that I removed all the reading code, as YARG won't be receiving anything so about 10k lines, if that weight doesn't matter I'll try the package. |
| _sendClient = new SACNClient(senderId: AcnSourceId, senderName: ACN_SOURCE_NAME, | ||
| localAddress: SACNCommon.GetFirstBindAddress().IPAddress); | ||
|
|
||
| InvokeRepeating(nameof(Sender), 0, TIME_BETWEEN_CALLS); |
There was a problem hiding this comment.
InvokeRepeating is unoptimized if I remember correctly, and it's annoying to deal with, you should probably just use a timer within the Update method
There was a problem hiding this comment.
I attempted a few different things for this, unitask, timers, etc and they all seemed to be more erratic than InvokeRepeating. The sacn converter that receives these messages (from YARG) had an incoming fluctuating fps 27 - 46, whereas the InvokeRepeating gave it a rock solid 44. I'll try other methods again.
Assets/Script/Integration/StageKit/StageKitLightingController.cs
Outdated
Show resolved
Hide resolved
| m_FloatArgument: 0 | ||
| m_StringArgument: | ||
| m_BoolArgument: 0 | ||
| m_CallState: 2 | ||
| m_OnSubmit: |
There was a problem hiding this comment.
Haven't looked at this in Unity yet, so it's hard to tell; is this change intentional?
There was a problem hiding this comment.
Probably not. I don't even know what kind of change that is. Only thing I did with InputField is added 8 of them to the DMX prefab.
Overall, I'd recommend packages when possible, so things aren't a pain to update. |
|
|
Damn okay, in which case we don't have much of a choice |
|
You could ask if the package's framework targets can be updated. It should have no issues being listed for .NET Standard 2.1 if it's set to target .NET 7. https://learn.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-1 |
|
Yeah if you could do that that'll be great; I'd rather not include a bunch of library files unless absolutely necessary. |
…ies (#682) * DMX support, "Advanced" tab, Stagekit toggle (#670) * DMX support Added scan (dmx over ethernet) support. Added an advanced settings tab. Added ability to turn off the stage kit. * fixed var names * Moved things to correct spots * Refactored into a MonoSingleton * Added README to note changes --------- Co-authored-by: EliteAsian <29520859+EliteAsian123@users.noreply.github.com> * Fix some things up * Make it so settings don't use tab in unlocalized name * Started "All Settings" menu * Split up advanced settings into their own categories and added some more buttons * Fixed a small bug that Jaden would totally fine 10 seconds after this update releases * Updated setting category view to concept * Updated search bar * Updated placeholder text styling * Added basic search functionality * Limit number of results * Fixed scrolling on scroll views * Make the search results clickable * Added more icons * Prevent SacnController from initializing twice --------- Co-authored-by: TheFatBastid <tfb@sof.ws>
Added scan (dmx over ethernet) support. Added an advanced settings tab. Added ability to turn off the stage kit.
Haukcode.sACN is now MIT licensed.