Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove day of week requirement from fetch and processor #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

froboy
Copy link

@froboy froboy commented Jul 16, 2024

Redo #15 after #16.

Copy link

@YusaYCloud YusaYCloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me - thank you for making these changes Avi.

@froboy froboy marked this pull request as draft July 16, 2024 18:08
@anpolimus
Copy link

@froboy I thought that days value is required for Activity Finder to function well.
Isnt it?

@froboy
Copy link
Author

froboy commented Nov 7, 2024

SCR-20241107-ijrk

@anpolimus "Day of week" is good to have, but not required. Some filters will not show items without it, but Denver had some child care sessions that were not listing it and I had tested this out. We did not end up using this change, which I think is why I left it in draft, but it is an option if folks need it.

@froboy froboy marked this pull request as ready for review November 7, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants