RN-2841 Memory leak with fetch function

From: facebook/react-native#25884 String data passed from native to js would leak a JSStringRef.
YOU-i-Labs · Apr 3, 2020 · 3e60682 · 3e60682
1 parent f17cb9b
commit 3e60682
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/ReactCommon/jsi/JSCRuntime.cpp b/ReactCommon/jsi/JSCRuntime.cpp
@@ -630,7 +630,9 @@ jsi::String JSCRuntime::createStringFromUtf8(
     size_t length) {
   std::string tmp(reinterpret_cast<const char*>(str), length);
   JSStringRef stringRef = JSStringCreateWithUTF8CString(tmp.c_str());
-  return createString(stringRef);
+  auto result = createString(stringRef);
+  JSStringRelease(stringRef);
+  return result;
 }
 
 std::string JSCRuntime::utf8(const jsi::String& str) {