Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintended behaviour with other plugins... #6

Closed
5 tasks done
WPS12TA opened this issue Dec 14, 2023 · 9 comments
Closed
5 tasks done

Unintended behaviour with other plugins... #6

WPS12TA opened this issue Dec 14, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@WPS12TA
Copy link

WPS12TA commented Dec 14, 2023

Code of Conduct

Submission validity

  • This is not a personal support request, that should be posted on discussions community.
  • I checked current issues and this request isn't a duplicate of an existing issue, opened or closed.

Self troubleshooting

Version

1.8

Description

I had installed this plugin and it was working very well. Thank you.
However, I then went on to install the QR-code plugin that converts a shortened url.qr into a QR code. I wanted and expected that to work. I discovered this plugin 'jumps in first' and gives a Not Found message and will not let the QR code plugin work until this plugin is deactivated, then the QR plugin worked. I am sure you would prefer both the plugins to play better with each other rather than fight in an either or way.
It seems the order of processing is not ideal.
Apologies as I am very new to all this but this is such a great system and I hope the fix is easy or the documentation could be explicit for this behaviour.

Expectation

Both plugins to work when both activated.

Reproduction steps

Install this and QR-code plugin activate them both and try the .qr hack to make a QR code.

Context

I think I have explained the problem clearly.

@WPS12TA WPS12TA added the bug Something isn't working label Dec 14, 2023
@WPS12TA
Copy link
Author

WPS12TA commented Dec 15, 2023

It looks as though they can play together, providing this 404 plugin is activated AFTER the QR code one is activated.

@ozh
Copy link
Member

ozh commented Dec 15, 2023

Which QR code plugin is it ?

@WPS12TA
Copy link
Author

WPS12TA commented Dec 16, 2023 via email

@ozh
Copy link
Member

ozh commented Dec 16, 2023

If you can re-create the original scenario where both plugins were conflicting, I'd be interested with your reporting about one change : in the QR code plugin, change yourls_add_action('redirect_keyword_not_found', 'ozh_yourls_qrcode'); with yourls_add_action('redirect_keyword_not_found', 'ozh_yourls_qrcode', 1); (line 12)

@WPS12TA
Copy link
Author

WPS12TA commented Dec 16, 2023 via email

ozh added a commit to YOURLS/website that referenced this issue Dec 16, 2023
@ozh
Copy link
Member

ozh commented Dec 16, 2023

Both plugins updated -- thanks

@ozh ozh closed this as completed Dec 16, 2023
ozh added a commit to YOURLS/website that referenced this issue Dec 16, 2023
@WPS12TA
Copy link
Author

WPS12TA commented Dec 16, 2023 via email

@WPS12TA
Copy link
Author

WPS12TA commented Dec 20, 2023 via email

@WPS12TA
Copy link
Author

WPS12TA commented Dec 22, 2023

Code of Conduct

Submission validity

  • This is not a personal support request, that should be posted on discussions community.
  • I checked current issues and this request isn't a duplicate of an existing issue, opened or closed.

Self troubleshooting

Version

1.8

Description

I had installed this plugin and it was working very well. Thank you. However, I then went on to install the QR-code plugin that converts a shortened url.qr into a QR code. I wanted and expected that to work. I discovered this plugin 'jumps in first' and gives a Not Found message and will not let the QR code plugin work until this plugin is deactivated, then the QR plugin worked. I am sure you would prefer both the plugins to play better with each other rather than fight in an either or way. It seems the order of processing is not ideal. Apologies as I am very new to all this but this is such a great system and I hope the fix is easy or the documentation could be explicit for this behaviour.

Expectation

Both plugins to work when both activated.

Reproduction steps

Install this and QR-code plugin activate them both and try the .qr hack to make a QR code.

Context

I think I have explained the problem clearly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants