Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube) Add Settings icons #152

Closed
wants to merge 3 commits into from
Closed

Conversation

anddea
Copy link

@anddea anddea commented Mar 6, 2024

@NeeRaj-2401
Copy link

woahh, nice work done @anddea , if possible please do consider to discuss/open same thing into revanced-patches as well, its worth the efforts :)

Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@anddea
Copy link
Author

anddea commented Mar 7, 2024

woahh, nice work done @anddea , if possible please do consider to discuss/open same thing into revanced-patches as well, its worth the efforts :)

There will be a little different implementation for the original ReVanced. I'm not looking into contributing there at the moment. They reject and close almost everything without a second thought. A few days ago, they did it again, you can find that issue Modernize SB in their repo. People have moved my code and resources there before, and if someone wants to move this feature there, they can do that. I think I'm not done with the icons yet.

I have releases in my repo if you want to test it.

@YT-Advanced YT-Advanced force-pushed the main branch 3 times, most recently from 65b2a22 to f9fa863 Compare March 11, 2024 09:28
@anddea anddea closed this Mar 11, 2024
@anddea anddea deleted the preficons branch March 11, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants