Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set Key::Release on hotkey end #28

Closed
kchibisov opened this issue Sep 30, 2023 · 0 comments · Fixed by #58
Closed

Don't set Key::Release on hotkey end #28

kchibisov opened this issue Sep 30, 2023 · 0 comments · Fixed by #58
Labels
bug Something isn't working

Comments

@kchibisov
Copy link
Contributor

Some applications may run their bindings on a Release of the key, like firefox.

You can test it muting itself with Mod+m binding.
@YaLTeR YaLTeR added the bug Something isn't working label Sep 30, 2023
kchibisov added a commit to kchibisov/niri that referenced this issue Oct 27, 2023
@kchibisov
Don't send key on release from niri actions
44849fa 
Some clients run logic on `Release`, thus don't send the key originally
used for running `niri` actions.

Fixes YaLTeR#28.
@kchibisov kchibisov mentioned this issue Oct 27, 2023
Merged
kchibisov added a commit to kchibisov/niri that referenced this issue Oct 27, 2023
@kchibisov
Don't send key on release from niri actions
a36a8ac 
Some clients run logic on `Release`, thus don't send the key originally
used for running `niri` actions.

Fixes YaLTeR#28.
kchibisov added a commit to kchibisov/niri that referenced this issue Oct 29, 2023
@kchibisov
Don't send key on release from niri actions
0f4e0d2 
Some clients run logic on `Release`, thus don't send the key originally
used for running `niri` actions.

Fixes YaLTeR#28.
YaLTeR pushed a commit that referenced this issue Oct 29, 2023
@kchibisov @YaLTeR
Don't send key on release from niri actions
5c24754 
Some clients run logic on `Release`, thus don't send the key originally
used for running `niri` actions.

Fixes #28.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't send key on release from niri actions kchibisov/niri
2 participants
@YaLTeR @kchibisov