Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ever, here's a fix otherwise completely crashes the react-native apps (when in release mode).
Problem
Crash occurs whenever there is a connection error.
Essentially, since the error is thrown outside of the main run loop, react-native just crashes the app (there is no real way to avoid that currently).
Throwing from within a
setTimeout()
, makes it that the error is uncatchable anyway.Solution
This prevents the crash and reports the error.
The readyState should be in CLOSED after this, which makes it consistent with the native EventSource behavior.
Note
As an aside, there's more fixes needed for SSE to work on expo & react-native, but that's not caused by this lib. I'll post links to the fix when i've created the relevant bugs