Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

loader metadata per lang #616

Merged
merged 8 commits into from
Oct 12, 2012
Merged

Conversation

caridy
Copy link
Contributor

@caridy caridy commented Oct 11, 2012

  • centralized configuration through application.json->yui->config for loader on server, loader on client, combo handler and application in general.
  • loader-app-base and loader-app-full should be lang aware for performance reasons
  • define a new way to configure the metadata url
  • define a way to enable/disable metadata as part of the seed (aka yui->config-url)

@caridy
Copy link
Contributor Author

caridy commented Oct 11, 2012

More work to be done on this.

…evel, and also logLevelOrder to modify the default value.
…y lang meta if controller is not common of client. passing request lang as part of the seed url.
…s part of the metadata resolution to avoid mixing server and client side dependencies. adding request as a dependency due to the nature of yui-sandbox implementation.
@@ -46,6 +47,10 @@ var libfs = require('fs'),
MODULE_META_PRIVATE_ENTRIES = ['after', 'expanded', 'supersedes', 'ext', '_parsed', '_inspected',
'skinCache', 'langCache'],

REGEX_LANG_TOKEN = /\"\{langToken\}\"/g,
REGEX_LANG_PATH = /\{langPath\}/g,
REGEX_LOCALE = /\_([a-z]{2}-[A-Z]{2})$/,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to watch for simple 'en' or 'de' here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, I will generalize that.

@mojit0
Copy link
Contributor

mojit0 commented Oct 12, 2012

Other than optional nits, +1

caridy added a commit that referenced this pull request Oct 12, 2012
loader metadata per lang

- new centralized configuration through application.json->yui->config for loader on server, loader on client, combo handler and application in general.

- new experimental yui-sandbox to be able to isolate processes (like client side metadata computation)

- enhance loader-app-base and loader-app-full to be lang aware for performance reasons

- define a way to configure the metadata url through application.json->yui-config->url
@caridy caridy merged commit 45358c1 into YahooArchive:develop-perf Oct 12, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants