This repository has been archived by the owner on Jul 24, 2020. It is now read-only.
[724] Set minimum height for Reservations table #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,3 +3,7 @@ | |||
| border-radius: 5px; | |||
| margin-bottom: 20px; | |||
| } | |||
|
|
|||
| #reservations-list { | |||
| height: 10em; | |||
There was a problem hiding this comment.
is this better than min-height for this use case?
There was a problem hiding this comment.
Little-known fact - tables don't have a min-height property; way to not read the issue thread 😛.
There was a problem hiding this comment.
lmao thanks, I was looking at PRs I didn't see the issue xD
There was a problem hiding this comment.
Didn't you teach me that the first step of code review is to read the relevant issue? Maybe I just made it up 😛
There was a problem hiding this comment.
depends on the level of code review ^_~
- shallow - cursory-glance feedback for obvious little things
- read-only - for style/architecture
- clone-and-manually-test - needed sometimes
Feedback of type 1 from busy people (Adam lol) has helped me more often than you'd think :)
|
looks fine to me |
orenyk
added a commit
that referenced
this pull request
Nov 23, 2015
[724] Set minimum height for Reservations table
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #724