Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Elapsed time include the time that users are choosing some options before hayabusa load evtx and detect alert. #1291

Closed
hach1yon opened this issue Mar 2, 2024 · 0 comments · Fixed by #1296
Assignees
Labels
bug Something isn't working
Milestone

Comments

@hach1yon
Copy link
Collaborator

hach1yon commented Mar 2, 2024

Describe the bug
As you know, hayabusa show Elasped time like following.

Elapsed time: 00:01:00.210

Please report any issues with Hayabusa rules to: https://github.com/Yamato-Security/hayabusa-rules/issues
Please report any false positives with Sigma rules to: https://github.com/SigmaHQ/sigma/issues
Please submit new Sigma rules with pull requests to: https://github.com/SigmaHQ/sigma/pulls 

It seems that Elapsed time include the time that users are choosing some options before hayabusa load evtx and detect alert.
I mean options are followings.

❯ 1. Core (1617 rules) ( status: test, stable | level: high, critical )
  2. Core+ (2723 rules) ( status: test, stable | level: medium, high, critical )
  3. Core++ (3718 rules) ( status: experimental, test, stable | level: medium, high, critical )
  4. All alert rules (4208 rules) ( status: * | level: low+ )
  5. All event and alert rules (4314 rules) ( status: * | level: informational+ )
✔ Include Emerging Threats rules? (218 rules) · yes
? Include sysmon rules? (799 rules) (y/n) › yes

I think we don't have to include the time that users are choosing some options into Elasped time.

Step to Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • OS: [e.g. Windows 10 Version 20H2]
  • hayabusa version [e.g. v1.0.0]

Additional context
Add any other context about the problem here.

@hach1yon hach1yon added the bug Something isn't working label Mar 2, 2024
@hach1yon hach1yon changed the title [bug] Elasped time is not accurate [bug] Elapsed time include the time that users are choosing some options before hayabusa load evtx and detect alert. Mar 2, 2024
@hitenkoku hitenkoku self-assigned this Mar 2, 2024
@YamatoSecurity YamatoSecurity added this to the v2.14.0 milestone Mar 4, 2024
hitenkoku added a commit that referenced this issue Mar 5, 2024
@hitenkoku hitenkoku linked a pull request Mar 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants