Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed new line characters in search output #1262

Merged
merged 2 commits into from
Feb 2, 2024
Merged

removed new line characters in search output #1262

merged 2 commits into from
Feb 2, 2024

Conversation

hitenkoku
Copy link
Collaborator

What Changed

  • removed newline characters in search command output

I would appreciate it if you could review when you have time.

@hitenkoku hitenkoku added the invalid This doesn't seem right label Feb 1, 2024
@hitenkoku hitenkoku self-assigned this Feb 1, 2024
@hitenkoku hitenkoku linked an issue Feb 1, 2024 that may be closed by this pull request
Remove new line characters in search output #1253
Closed
@hitenkoku
Copy link
Collaborator Author

hitenkoku commented Feb 1, 2024 •
edited
Loading

Evidence

I confirmed replaced newline charcater to space character in AccessList.

❯  ./1253.exe  search -d ../hayabusa-sample-evtx -r ".*" -F EventID:"5145"

...

2022-02-16 19:37:20.451 +09:00 · 01566s-win16-ir.threebeesco.com · Sec · 5145 · 2988531 · Network share object checked for client access · AccessList: %%1538 %%1541 %%4416 %%4417 %%4418 %%4419 %%4420 %%4423 %%4424 ¦ AccessMask: 0x12019f ¦ AccessReason: - ¦ IpAddress: 172.16.66.25 ¦ IpPort: 50251 ¦ ObjectType: File ¦ RelativeTargetName: winreg ¦ ShareLocalPath:  ¦ ShareName: \\*\IPC$ ¦ SubjectDomainName: 3B ¦ SubjectLogonId: 0x567515 ¦ SubjectUserName: samir ¦ SubjectUserSid: S-1-5-21-308926384-506822093-3341789130-220106 · ../hayabusa-sample-evtx\EVTX-ATTACK-SAMPLES\Credential Access\remote_sam_registry_access_via_backup_operator_priv.evtx
2022-02-16 19:37:20.508 +09:00 · 01566s-win16-ir.threebeesco.com · Sec · 5145 · 2988532 · Network share object checked for client access · AccessList: %%1538 %%1541 %%4416 %%4417 %%4418 %%4419 %%4420 %%4423 %%4424 ¦ AccessMask: 0x12019f ¦ AccessReason: - ¦ IpAddress: 172.16.66.25 ¦ IpPort: 50251 ¦ ObjectType: File ¦ RelativeTargetName: winreg ¦ ShareLocalPath:  ¦ ShareName: \\*\IPC$ ¦ SubjectDomainName: 3B ¦ SubjectLogonId: 0x567515 ¦ SubjectUserName: samir ¦ SubjectUserSid: S-1-5-21-308926384-506822093-3341789130-220106 · ../hayabusa-sample-evtx\EVTX-ATTACK-SAMPLES\Credential Access\remote_sam_registry_access_via_backup_operator_priv.evtx
2022-02-16 19:37:20.534 +09:00 · 01566s-win16-ir.threebeesco.com · Sec · 5145 · 2988537 · Network share object checked for client access · AccessList: %%1538 %%1541 %%4417 %%4418 %%4420 %%4423 %%4424 ¦ AccessMask: 0x120196 ¦ AccessReason: - ¦ IpAddress: 172.16.66.36 ¦ IpPort: 64224 ¦ ObjectType: File ¦ RelativeTargetName: Users\PSAM ¦ ShareLocalPath: \??\C:\ ¦ ShareName: \\*\C$ ¦ SubjectDomainName: 3B ¦ SubjectLogonId: 0x567758 ¦ SubjectUserName: samir ¦ SubjectUserSid: S-1-5-21-308926384-506822093-3341789130-220106 · ../hayabusa-sample-evtx\EVTX-ATTACK-SAMPLES\Credential Access\remote_sam_registry_access_via_backup_operator_priv.evtx
2022-02-16 19:37:20.534 +09:00 · 01566s-win16-ir.threebeesco.com · Sec · 5145 · 2988538 · Network share object checked for client access · AccessList: %%4417 ¦ AccessMask: 0x2 ¦ AccessReason: - ¦ IpAddress: 172.16.66.36 ¦ IpPort: 64224 ¦ ObjectType: File ¦ RelativeTargetName: Users\PSAM ¦ ShareLocalPath: \??\C:\ ¦ ShareName: \\*\C$ ¦ SubjectDomainName: 3B ¦ SubjectLogonId: 0x567758 ¦ SubjectUserName: samir ¦ SubjectUserSid: S-1-5-21-308926384-506822093-3341789130-220106 · ../hayabusa-sample-evtx\EVTX-ATTACK-SAMPLES\Credential Access\remote_sam_registry_access_via_backup_operator_priv.evtx
2022-02-16 19:37:20.550 +09:00 · 01566s-win16-ir.threebeesco.com · Sec · 5145 · 2988539 · Network share object checked for client access · AccessList: %%1538 %%1541 %%4417 %%4418 %%4420 %%4423 %%4424 ¦ AccessMask: 0x120196 ¦ AccessReason: - ¦ IpAddress: 172.16.66.36 ¦ IpPort: 64224 ¦ ObjectType: File ¦ RelativeTargetName: Users\PSYSTEM ¦ ShareLocalPath: \??\C:\ ¦ ShareName: \\*\C$ ¦ SubjectDomainName: 3B ¦ SubjectLogonId: 0x567758 ¦ SubjectUserName: samir ¦ SubjectUserSid: S-1-5-21-308926384-506822093-3341789130-220106 · ../hayabusa-sample-evtx\EVTX-ATTACK-SAMPLES\Credential Access\remote_sam_registry_access_via_backup_operator_priv.evtx
2022-02-16 19:37:20.550 +09:00 · 01566s-win16-ir.threebeesco.com · Sec · 5145 · 2988540 · Network share object checked for client access · AccessList: %%4417 ¦ AccessMask: 0x2 ¦ AccessReason: - ¦ IpAddress: 172.16.66.36 ¦ IpPort: 64224 ¦ ObjectType: File ¦ RelativeTargetName: Users\PSYSTEM ¦ ShareLocalPath: \??\C:\ ¦ ShareName: \\*\C$ ¦ SubjectDomainName: 3B ¦ SubjectLogonId: 0x567758 ¦ SubjectUserName: samir ¦ SubjectUserSid: S-1-5-21-308926384-506822093-3341789130-220106 · ../hayabusa-sample-evtx\EVTX-ATTACK-SAMPLES\Credential Access\remote_sam_registry_access_via_backup_operator_priv.evtx
2022-02-16 19:37:20.934 +09:00 · 01566s-win16-ir.threebeesco.com · Sec · 5145 · 2988542 · Network share object checked for client access · AccessList: %%4417 ¦ AccessMask: 0x2 ¦ AccessReason: - ¦ IpAddress: 172.16.66.36 ¦ IpPort: 64224 ¦ ObjectType: File ¦ RelativeTargetName: Users\PSECURITY ¦ ShareLocalPath: \??\C:\ ¦ ShareName: \\*\C$ ¦ SubjectDomainName: 3B ¦ SubjectLogonId: 0x567758 ¦ SubjectUserName: samir ¦ SubjectUserSid: S-1-5-21-308926384-506822093-3341789130-220106 · ../hayabusa-sample-evtx\EVTX-ATTACK-SAMPLES\Credential Access\remote_sam_registry_access_via_backup_operator_priv.evtx
2022-02-16 19:37:20.934 +09:00 · 01566s-win16-ir.threebeesco.com · Sec · 5145 · 2988541 · Network share object checked for client access · AccessList: %%1538 %%1541 %%4417 %%4418 %%4420 %%4423 %%4424 ¦ AccessMask: 0x120196 ¦ AccessReason: - ¦ IpAddress: 172.16.66.36 ¦ IpPort: 64224 ¦ ObjectType: File ¦ RelativeTargetName: Users\PSECURITY ¦ ShareLocalPath: \??\C:\ ¦ ShareName: \\*\C$ ¦ SubjectDomainName: 3B ¦ SubjectLogonId: 0x567758 ¦ SubjectUserName: samir ¦ SubjectUserSid: S-1-5-21-308926384-506822093-3341789130-220106 · ../hayabusa-sample-evtx\EVTX-ATTACK-SAMPLES\Credential Access\remote_sam_registry_access_via_backup_operator_priv.evtx


Total findings: 3059


Elapsed time: 00:00:13.423

@codecov Codecov
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (b138609) 82.21% compared to head (c6b3378) 82.18%.

Files Patch % Lines
src/timeline/search.rs 0.00% 12 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1262      +/-   ##
==========================================
- Coverage   82.21%   82.18%   -0.04%     
==========================================
  Files          27       27              
  Lines       24304    24313       +9     
==========================================
  Hits        19981    19981              
- Misses       4323     4332       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

YamatoSecurity
YamatoSecurity approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

fukusuket
fukusuket approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@fukusuket fukusuket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed -k -r both option works :) LGTM!!🚀

@hitenkoku
Copy link
Collaborator Author

Thanks for review!
I will merge it.

@hitenkoku hitenkoku merged commit e052fc5 into main Feb 2, 2024
9 checks passed
@hitenkoku hitenkoku deleted the 1253-remove-new-line-characters-in-search-output branch February 2, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YamatoSecurity YamatoSecurity YamatoSecurity approved these changes

@fukusuket fukusuket fukusuket approved these changes

Assignees

@hitenkoku hitenkoku

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove new line characters in search output
3 participants
@hitenkoku @fukusuket @YamatoSecurity