Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorder search result fields #1300

Merged
merged 3 commits into from
Mar 9, 2024
Merged

Conversation

hitenkoku
Copy link
Collaborator

What Changed

  • Reordered search result fields to look similar to the csv-timeline command results.

@hitenkoku hitenkoku added the enhancement New feature or request label Mar 7, 2024
@hitenkoku hitenkoku self-assigned this Mar 7, 2024
@hitenkoku hitenkoku linked an issue Mar 7, 2024 that may be closed by this pull request
@YamatoSecurity YamatoSecurity added this to the v2.14.0 milestone Mar 7, 2024
@YamatoSecurity
Copy link
Collaborator

@hitenkoku Thanks so much! The reordering looks good.
Sorry one more thing I noticed. At the end, the results look like this:

2023-04-14 17:25:12.223 +09:00 · - · WIN · MS-Win-WinINet-Config/ProxyConfigChanged · 5600 · 14 · fAutoDetect: false ¦ pwszAutoConfigUrl: http://hacker-bypass.com/ ¦ pwszProxy: http://hacker-proxy.lan:123 ¦ pwszProxyBypass: http://internal.lan;<local> · ../hayabusa-sample-evtx/EVTX-to-MITRE-Attack/TA0011-Command and Control/T1572-Protocol tunneling/ID5600-proxy configuration changed.evtx



Total findings: 47476


Elapsed time: 00:00:26.1103

Can you make it look like:

2023-04-14 17:25:12.223 +09:00 · - · WIN · MS-Win-WinINet-Config/ProxyConfigChanged · 5600 · 14 · fAutoDetect: false ¦ pwszAutoConfigUrl: http://hacker-bypass.com/ ¦ pwszProxy: http://hacker-proxy.lan:123 ¦ pwszProxyBypass: http://internal.lan;<local> · ../hayabusa-sample-evtx/EVTX-to-MITRE-Attack/TA0011-Command and Control/T1572-Protocol tunneling/ID5600-proxy configuration changed.evtx

Total findings: 47,476
Elapsed time: 00:00:26.1103

With only a single space on above and below the summary and display Total findings with commas.

Copy link
Collaborator

@fukusuket fukusuket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!🚀

@hitenkoku
Copy link
Collaborator Author

@YamatoSecurity Sorry for my late replying.
I fixed your pointed out in 369e35d.
Would you check it?

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 81.05%. Comparing base (ce04f24) to head (369e35d).

Files Patch % Lines
src/timeline/timelines.rs 0.00% 5 Missing ⚠️
src/timeline/search.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1300      +/-   ##
==========================================
- Coverage   81.06%   81.05%   -0.02%     
==========================================
  Files          27       27              
  Lines       24626    24629       +3     
==========================================
- Hits        19963    19962       -1     
- Misses       4663     4667       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hitenkoku LGTM! Thank you so much!

@hitenkoku hitenkoku merged commit 28df119 into main Mar 9, 2024
7 checks passed
@hitenkoku hitenkoku deleted the 1297-reorder-search-result-fields branch March 17, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorder search result fields
3 participants