Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort count rule's result filed value #1467

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

fukusuket
Copy link
Collaborator

@fukusuket fukusuket commented Nov 2, 2024

What Changed

Evidence

Integration-Test

All commands completed successfully.
https://github.com/Yamato-Security/hayabusa/actions/runs/11638671955

I ran the command five times and verified that there were no differences in the resulting files.

% ./hayabusa csv-timeline -d ../hayabusa-sample-evtx -w -o 1.csv -C
% ./hayabusa csv-timeline -d ../hayabusa-sample-evtx -w -o 2.csv -C
% ./hayabusa csv-timeline -d ../hayabusa-sample-evtx -w -o 3.csv -C
% ./hayabusa csv-timeline -d ../hayabusa-sample-evtx -w -o 4.csv -C
% ./hayabusa csv-timeline -d ../hayabusa-sample-evtx -w -o 4.csv -C
% diff 1.csv 2.csv
% diff 1.csv 3.csv
% diff 1.csv 4.csv
% diff 1.csv 5.csv

I would appreciate it if you could check it out when you have time🙏

@fukusuket fukusuket added the bug Something isn't working label Nov 2, 2024
@fukusuket fukusuket self-assigned this Nov 2, 2024
@fukusuket fukusuket marked this pull request as ready for review November 2, 2024 01:32
@fukusuket fukusuket added enhancement New feature or request and removed bug Something isn't working labels Nov 2, 2024
Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket LGTM! Thanks so much!

@YamatoSecurity YamatoSecurity merged commit 9499ba9 into main Nov 2, 2024
5 checks passed
@YamatoSecurity YamatoSecurity deleted the 1466-sort-count-rule-detection-result branch November 2, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Result files are not the same when running csv(json)-timeline command multiple times
2 participants