-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added channel names shorter in the metrics/csv-timeline/json-timeline command #927
Added channel names shorter in the metrics/csv-timeline/json-timeline command #927
Conversation
Codecov ReportBase: 74.82% // Head: 74.80% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #927 +/- ##
==========================================
- Coverage 74.82% 74.80% -0.03%
==========================================
Files 24 24
Lines 15935 15973 +38
==========================================
+ Hits 11924 11948 +24
- Misses 4011 4025 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I like how it does not give an error before a user updates and adds the new config file.
When I ran the update-rules
command, it did give an error saying it could not find the config file. Why is this?
./target/release/hayabusa update-rules
[ERROR] Cannot open file. [file:rules/config/channel_abbreviations_generic.txt]
The speed does decrease a little bit: 4:30 -> 4:20 but this is ok.
@fukusuket Please let us know if you know any ways to improve performance, etc...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the json result before and after commit with the following command:
fukusuke@fukusukenoAir hayabusa-2.2.0-all-platforms % cat main.json | jq '.Channel' | sort | uniq -c | sort -n
4 "App"
5 "WinRM"
6 "RDS-RCM"
13 "PwShClassic"
62 "RDS-LSM"
64 "Microsoft-Windows-Storage-Storport/Operational"
108 "-"
120 "BitsCli"
166 "TaskSch"
251 "Sys"
267 "PwSh"
293 "Firewall"
776 "WMI"
7103 "Sec"
1617909 "Sysmon"
fukusuke@fukusukenoAir hayabusa-2.2.0-all-platforms % cat new.json | jq '.Channel' | sort | uniq -c | sort -n
4 "App"
5 "WinRM"
6 "RDS-RCM"
13 "PwShClassic"
62 "RDS-LSM"
64 "MS-Win-Storage-Storport/Op"
108 "-"
120 "BitsCli"
166 "TaskSch"
251 "Sys"
267 "PwSh"
293 "Firewall"
776 "WMI"
7103 "Sec"
1617909 "Sysmon"
LGTM!! 🚀
I'll look for processes that can improve perf then create another PR :) 💪 |
What Changed
Evidence
main branch result