-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support cidr
rule
#961
Conversation
@fukusuket Thanks so much!
When I run
If I change |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #961 +/- ##
==========================================
+ Coverage 75.08% 75.24% +0.15%
==========================================
Files 24 24
Lines 16624 16719 +95
==========================================
+ Hits 12482 12580 +98
+ Misses 4142 4139 -3
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fukusuket Thank you for the pull request.
Please check the following points that have been brought to our attention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the comments added about the test cases.
Co-authored-by: DustInDark <2350416+hitenkoku@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Thank you so much for quick review and test :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.LGTM.
What Changed
|cidr
#955Evidence
Environment
Test
test.yml
is as follows.(no cidr match)then SrcIP uniq count is as follows
./hayabuse json-timeline -d ./hayabusa-sample-evtx -r test.yml -o result.json
cat result.json | jq .Details.SrcIP | sort | uniq -c
test.yml
is as follows.(with cidr match)then SrcIP uniq count is as follows
./hayabuse json-timeline -d ./hayabusa-sample-evtx -r test.yml -o result.json
cat result.json | jq .Details.SrcIP | sort | uniq -c
I confirm that the number of
SrcIP
matches before and after thecidr
filterI would appreciate it if you could review🙏