Add export meter support #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yanson
approved these changes
May 14, 2024
| points = [] | ||
| net_modifier = 1.0 | ||
| if export_meter: |
There was a problem hiding this comment.
I might have condensed this to one line as such:
net_modifier = -1.0 if export_meter else 1.0
|
I'm guessing the flow failure is a transient issue unrelated to the change? |
I think it's a credentials issue. Might be related to building from a fork. Happy to merge and see on main if you are. |
Yes, happy to merge. I have a bugfix and big feature update for a future PR also, the latter will require some reviewing though as it's fairly complex. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, "usage" and "cost" for export meters & tariffs are stored as negative values, which makes the default Grafana dashboard show correct "net" figures (e.g. 10 kWh import @ 10p/kWh and 5 kWh export @ 5p/kWh is shown as 5 kWh "total electricity used" and 75p "total cost" (assuming no standing charge in this example).