Skip to content

Commit

Permalink
Refactor libv8 unzip steps in CI workflows for improved clarity and c…
Browse files Browse the repository at this point in the history
…onsistency
  • Loading branch information
trheyi committed Nov 23, 2024
1 parent d58228c commit e3b585d
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 5 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/leakcheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@ jobs:

- name: Unzip libv8
run: |
files=$(find . -name "libv8.a.zip")
files=$(find . -name "libv8*.zip")
for file in $files; do
unzip -o -d $(dirname $file) $file
dir=$(dirname "$file") # Get the directory where the ZIP file is located
echo "Extracting $file to directory $dir"
unzip -o -d $dir $file
done
- name: Go Test
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,11 @@ jobs:

- name: Unzip libv8
run: |
files=$(find . -name "libv8-*.zip")
files=$(find . -name "libv8*.zip")
for file in $files; do
unzip -o -d $(dirname $file) $file
dir=$(dirname "$file") # Get the directory where the ZIP file is located
echo "Extracting $file to directory $dir"
unzip -o -d $dir $file
done
- name: Go Test
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/v8build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,18 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
with:
lfs: true
submodules: true
fetch-depth: 1

- name: Unzip libv8
run: |
files=$(find . -name "libv8*.zip")
for file in $files; do
dir=$(dirname "$file") # Get the directory where the ZIP file is located
echo "Extracting $file to directory $dir"
unzip -o -d $dir $file
done
- name: Update depot_tools fetch config
run: cd deps/depot_tools && git config --unset-all remote.origin.fetch; git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/*
shell: bash
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,5 @@ deps/.gclient_previous*
c.out
.idea/*
/v8go.test
deps/*/libv8.a
deps/*/__MACOSX

0 comments on commit e3b585d

Please sign in to comment.